Message-id: <54E1F511.1090604@samsung.com>
Date: Mon, 16 Feb 2015 22:48:01 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106
 Thunderbird/17.0.2
MIME-version: 1.0
To: Lee Jones <lee.jones@linaro.org>
Cc: Jaewon Kim <jaewon02.kim@samsung.com>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
        Inki Dae <inki.dae@samsung.com>,
        SangBae Lee <sangbae90.lee@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Sebastian Reichel <sre@kernel.org>,
        Mark Brown <broonie@kernel.org>, Beomho Seo <beomho.seo@samsung.com>
Subject: Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver
References: <1423025771-4139-1-git-send-email-jaewon02.kim@samsung.com>
 <1423025771-4139-2-git-send-email-jaewon02.kim@samsung.com>
 <54D20A32.1020604@samsung.com> <20150216134206.GH14545@x1>
In-reply-to: <20150216134206.GH14545@x1>
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 7bit
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1457
Lines: 40

On 02/16/2015 10:42 PM, Lee Jones wrote:
> On Wed, 04 Feb 2015, Chanwoo Choi wrote:
>> On 02/04/2015 01:56 PM, Jaewon Kim wrote:
>>> This patch adds MAX77843 core/irq driver to support PMIC,
>>> MUIC(Micro USB Interface Controller), Charger, Fuel Gauge,
>>> LED and Haptic device.
>>>
>>> Cc: Lee Jones <lee.jones@linaro.org>
>>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
>>> ---
>>>  drivers/mfd/Kconfig                  |   14 ++
>>>  drivers/mfd/Makefile                 |    1 +
>>>  drivers/mfd/max77843.c               |  245 +++++++++++++++++++
>>>  include/linux/mfd/max77843-private.h |  441 ++++++++++++++++++++++++++++++++++
>>>  4 files changed, 701 insertions(+)
>>>  create mode 100644 drivers/mfd/max77843.c
>>>  create mode 100644 include/linux/mfd/max77843-private.h
> 
> <LOTS OF POINTLESS LINES OF UNCHANGED/UNREVIEWED CODE>
> 
>> Looks good to me.
>>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> 
> Chanwoo,
> 
> If you're not going to make any comments, either put the Reviewed-by
> at the top, or better still, snip out all of the bumph in the middle.
> 

OK, I'll do according your comment.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/