Date: Mon, 16 Feb 2015 10:10:45 -0600
From: Tom Huynh <tommy.xhuynh@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
CC: Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        "Peter Zijlstra" <peterz@infradead.org>,
        Tom Huynh <tom.huynh@freescale.com>, <benh@kernel.crashing.org>,
        <paulus@samba.org>, <mpe@ellerman.id.au>, <mingo@redhat.com>,
        <acme@kernel.org>, <Kim.Phillips@freescale.com>,
        <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] perf/e6500: Make event translations available in
 sysfs
Message-ID: <20150216161045.GA32564@rivendell>
References: <1423262636-12053-1-git-send-email-tom.huynh@freescale.com>
 <1423262636-12053-2-git-send-email-tom.huynh@freescale.com>
 <20150209100242.GM23123@twins.programming.kicks-ass.net>
 <20150209100738.GA5461@gmail.com> <20150209121132.GB3952@krava.redhat.com>
 <20150209132557.GA8099@gmail.com> <20150209204019.GA13991@two.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20150209204019.GA13991@two.firstfloor.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2015 16:12:32.1005
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0738
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1885
Lines: 43

On Mon, Feb 09, 2015 at 09:40:19PM +0100, Andi Kleen wrote:
> > I'll NAK any external 'download area' (and I told that Andi 
> > before): tools/perf/event-tables/ or so is a good enough 
> > 'download area' with fast enough update cycles.
> 
> The proposal was to put it on kernel.org, similar to how
> external firmware blobs are distributed. CPU event lists
> are data sheets, so are like firmware. They do not
> follow the normal kernel code licenses. They are not 
> source code. They cannot be reviewed in the normal way.
 
Could you provide more details about the license and review 
concern? How are the event list files different from hardware-
specific information (e.g. reg mapping) in header files?

> > If any 'update' of event descriptions is needed it can 
> > happen through the distro package mechanism, or via a 
> > simple 'git pull' if it's compiled directly.
> > 
> > Lets not overengineer this with any dependence on an 
> > external site and with a separate update mechanism - lets 
> > just get the tables into tools/ and see it from there...
> 
> That experiment has been already done for oprofile,
> didn't work very well.

Please excuse my ignorance, could you say exactly what didn't
work well for oprofile?

Ingo's suggestion seems good to me because these event files 
will be transparent to the users, and it's just more 
convenient not having to go to a website to look for 
the event file that matches the machine to download.
The distro package or the perf make mechanism can put these
files into the appropriate directory. The users who are not
perf developers won't need to know about these files.

- Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/