Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032AbbBPQ72 (ORCPT ); Mon, 16 Feb 2015 11:59:28 -0500 Received: from smtp205.alice.it ([82.57.200.101]:38201 "EHLO smtp205.alice.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753102AbbBPQ70 (ORCPT ); Mon, 16 Feb 2015 11:59:26 -0500 Date: Mon, 16 Feb 2015 17:59:21 +0100 From: Antonio Ospite To: linux-input@vger.kernel.org Cc: Lauri Kasanen , jkosina@suse.cz, linux-kernel@vger.kernel.org, benjamin.tissoires@gmail.com, AndrewD207@aol.com Subject: Re: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Message-Id: <20150216175921.05ce3e9326e9aacbb9f77795@ao2.it> In-Reply-To: <20150216150659.db522f3d.cand@gmx.com> References: <20150216150659.db522f3d.cand@gmx.com> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) X-Face: z*RaLf`X<@C75u6Ig9}{oW$H;1_\2t5)({*|jhM/Vb;]yA5\I~93>J<_`<4)A{':UrE Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2549 Lines: 93 On Mon, 16 Feb 2015 15:06:59 +0200 Lauri Kasanen wrote: > Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send > any events. Now everything works including the leds. > > Based on work by Andrew Haines and Antonio Ospite. > > cc: Antonio Ospite > cc: Andrew Haines > Signed-off-by: Lauri Kasanen Reviewed-by: Antonio Ospite Original controllers still work fine after this change. Some follow-up patches are on their way. Thanks, Antonio > --- > drivers/hid/hid-sony.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > Antonio: size 8 works. > > v4: > - use size 8 > > v3: > - reuse the dummy heap buffer > - skip later checks if the earlier ones fail > > v2: > - edited error messages > - use output_report > > diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c > index 31e9d25..f3d44e5 100644 > --- a/drivers/hid/hid-sony.c > +++ b/drivers/hid/hid-sony.c > @@ -1139,9 +1139,29 @@ static int sixaxis_set_operational_usb(struct hid_device *hdev) > ret = hid_hw_raw_request(hdev, 0xf2, buf, 17, HID_FEATURE_REPORT, > HID_REQ_GET_REPORT); > > + if (ret < 0) { > + hid_err(hdev, "can't set operational mode: step 1\n"); > + goto out; > + } > + > + /* > + * Some compatible controllers like the Speedlink Strike FX and > + * Gasia need another query plus an USB interrupt to get operational. > + */ > + ret = hid_hw_raw_request(hdev, 0xf5, buf, 8, HID_FEATURE_REPORT, > + HID_REQ_GET_REPORT); > + > + if (ret < 0) { > + hid_err(hdev, "can't set operational mode: step 2\n"); > + goto out; > + } > + > + ret = hid_hw_output_report(hdev, buf, 1); > + > if (ret < 0) > - hid_err(hdev, "can't set operational mode\n"); > + hid_err(hdev, "can't set operational mode: step 3\n"); > > +out: > kfree(buf); > > return ret; > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/