Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753915AbbBPSqj (ORCPT ); Mon, 16 Feb 2015 13:46:39 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:42301 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbbBPSqh (ORCPT ); Mon, 16 Feb 2015 13:46:37 -0500 MIME-Version: 1.0 In-Reply-To: <20150216090054.62455465@tlielax.poochiereds.net> References: <20150209055540.2f2a3689@tlielax.poochiereds.net> <20150216133200.GB3270@node.dhcp.inet.fi> <20150216090054.62455465@tlielax.poochiereds.net> Date: Mon, 16 Feb 2015 10:46:36 -0800 X-Google-Sender-Auth: SwiWIVzZK8vu3fX1QHj1u_zvQD4 Message-ID: Subject: Re: [GIT PULL] please pull file-locking related changes for v3.20 From: Linus Torvalds To: Jeff Layton Cc: "Kirill A. Shutemov" , linux-fsdevel , Linux Kernel Mailing List , "J. Bruce Fields" , Christoph Hellwig , Dave Chinner , Sasha Levin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 31 On Mon, Feb 16, 2015 at 6:00 AM, Jeff Layton wrote: > > I'll look at it again and also see if I can reproduce it with trinity. > So far, I haven't been able to, but maybe I'll get lucky this time. Can you please also remove the completely broken counters? The f*ckers aren't even initialized, they are never used outside of completely broken cifs code (hint: it doesn't take the spinlock, so it just uses the counters as a random-number-generator), and even there it would be better to just count the list instead of maintaining a count of list entries - and doing it *wrong*. The lock counters are broken. Get rid of them. Seriously. The reason I care is that I tried to read the code to manage the locks in fs/locks.c, and just passing the pointer to the counter around made it unreadable. And when I actually tried to read it, and look at the initialization, I see that they are never initialized. This code is so broken that my initial reaction is "We need to just revert the crap". And no. The fix is *not* to just initialize those stupid things to zero. The fix is to remove them. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/