Message-id: <54E24428.5070804@partner.samsung.com>
Date: Mon, 16 Feb 2015 22:25:28 +0300
From: Stefan Strogin <s.strogin@partner.samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.4.0
MIME-version: 1.0
To: SeongJae Park <sj38.park@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Michal Nazarewicz <mina86@mina86.com>, aneesh.kumar@linux.vnet.ibm.com,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Dmitry Safonov <d.safonov@partner.samsung.com>,
        Pintu Kumar <pintu.k@samsung.com>,
        Weijie Yang <weijie.yang@samsung.com>,
        Laura Abbott <lauraa@codeaurora.org>, Hui Zhu <zhuhui@xiaomi.com>,
        Minchan Kim <minchan@kernel.org>, Dyasly Sergey <s.dyasly@samsung.com>,
        Vyacheslav Tyrtov <v.tyrtov@samsung.com>, gregory.0xf0@gmail.com,
        sasha.levin@oracle.com, gioh.kim@lge.com, pavel@ucw.cz,
        stefan.strogin@gmail.com
Subject: Re: [PATCH 1/4] mm: cma: add currently allocated CMA buffers list to
 debugfs
References: <cover.1423777850.git.s.strogin@partner.samsung.com>
 <c4f408198ec7ea7656ae29220c1f96081bd2ade5.1423777850.git.s.strogin@partner.samsung.com>
 <alpine.DEB.2.10.1502132313010.23105@hxeon>
In-reply-to: <alpine.DEB.2.10.1502132313010.23105@hxeon>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 33

Hello SeongJae,

On 13/02/15 17:18, SeongJae Park wrote:
> Hello, Stefan.
> 
> On Fri, 13 Feb 2015, Stefan Strogin wrote:
> 
>> #include <linux/io.h>
>> +#include <linux/list.h>
>> +#include <linux/proc_fs.h>
>> +#include <linux/time.h>
> 
> Looks like `proc_fs.h` and `time.h` are not necessary.
> 

Yes, of course. Thanks.


>> +        pr_warn("%s(page %p, count %d): failed to allocate buffer
>> list entry\n",
>> +            __func__, pfn_to_page(pfn), count);
> 
> pfn_to_page() would cause build failure on x86_64. Why don't you include
> appropriate header file?
> 

Indeed. Because I tested it only on arm and x86. Sorry :( Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/