Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751158AbbBPTjU (ORCPT ); Mon, 16 Feb 2015 14:39:20 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50575 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbbBPTjT (ORCPT ); Mon, 16 Feb 2015 14:39:19 -0500 Date: Mon, 16 Feb 2015 11:39:17 -0800 From: Greg Kroah-Hartman To: Joseph Kogut Cc: Bjorn Helgaas , Felipe Balbi , USB list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h Message-ID: <20150216193917.GA9296@kroah.com> References: <1424045863-27293-1-git-send-email-joseph.kogut@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 639 Lines: 13 On Mon, Feb 16, 2015 at 09:27:09AM -0700, Joseph Kogut wrote: > It seems that the Synopsys vendor ID is used in usb/dwc2 as well, and > the rest of the definitions aren't referenced outside of usb/dwc3. > Would the proper approach be to move the Synopsys vendor ID to > linux/pci_ids.h, remove the redefinition in usb/dwc2, and remove the > fixme? That sounds like the "correct" fix for this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/