Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbbBPTm2 (ORCPT ); Mon, 16 Feb 2015 14:42:28 -0500 Received: from cmexedge1.emulex.com ([138.239.224.99]:32303 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbbBPTm1 (ORCPT ); Mon, 16 Feb 2015 14:42:27 -0500 Message-ID: <54E24806.5030605@emulex.com> Date: Mon, 16 Feb 2015 14:41:58 -0500 From: James Smart Reply-To: User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Thadeu Lima de Souza Cascardo CC: , , Subject: Re: [PATCH] scsi/lpfc: use remove handler as shutdown handler References: <1422285538-487-1-git-send-email-cascardo@linux.vnet.ibm.com> In-Reply-To: <1422285538-487-1-git-send-email-cascardo@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1400 Lines: 41 Looks good. Acked-By: James Smart -- james On 1/26/2015 10:18 AM, Thadeu Lima de Souza Cascardo wrote: > Without a shutdown handler, some cards behave very badly after a kexec. > During probe, pending DMA writes will corrupt kernel memory, for > example. > > Using the remove handler guarantees we will use a well tested path. > > With this patch I applied, I managed to use kexec multiple times and > probe and SCSI scan worked every time. > > Signed-off-by: Thadeu Lima de Souza Cascardo > --- > drivers/scsi/lpfc/lpfc_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 0b2c53a..8aa804a 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -11248,6 +11248,7 @@ static struct pci_driver lpfc_driver = { > .id_table = lpfc_id_table, > .probe = lpfc_pci_probe_one, > .remove = lpfc_pci_remove_one, > + .shutdown = lpfc_pci_remove_one, > .suspend = lpfc_pci_suspend_one, > .resume = lpfc_pci_resume_one, > .err_handler = &lpfc_err_handler, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/