Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbbBQAVd (ORCPT ); Mon, 16 Feb 2015 19:21:33 -0500 Received: from mail-ie0-f182.google.com ([209.85.223.182]:37793 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbbBQAVb (ORCPT ); Mon, 16 Feb 2015 19:21:31 -0500 MIME-Version: 1.0 In-Reply-To: <20150216190254.3b66a9ba@tlielax.poochiereds.net> References: <20150209055540.2f2a3689@tlielax.poochiereds.net> <20150216133200.GB3270@node.dhcp.inet.fi> <20150216090054.62455465@tlielax.poochiereds.net> <20150216190254.3b66a9ba@tlielax.poochiereds.net> Date: Mon, 16 Feb 2015 16:21:30 -0800 X-Google-Sender-Auth: luPSRrbOXw7hY4jHRO30kvOefl8 Message-ID: Subject: Re: [GIT PULL] please pull file-locking related changes for v3.20 From: Linus Torvalds To: Jeff Layton Cc: "Kirill A. Shutemov" , linux-fsdevel , Linux Kernel Mailing List , "J. Bruce Fields" , Christoph Hellwig , Dave Chinner , Sasha Levin Content-Type: multipart/mixed; boundary=001a113f2aa63398f7050f3daf23 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4139 Lines: 73 --001a113f2aa63398f7050f3daf23 Content-Type: text/plain; charset=UTF-8 On Mon, Feb 16, 2015 at 4:02 PM, Jeff Layton wrote: > > Now that I look, it may be best to just revert this whole set for now. > Linus, are you amenable to doing that? Sure. But I'd prefer seeing how hard it would be to fix things first. If this was at the end of the release cycle, I'd revert it immediately. As it is, try to see how had it is. The bugs I found might be as easy as just the attached (TOTALLY UNTESTED) patch. The comment about a higher-priority process and sched_resced() is just complete and utter crap. If somebody holds a read lock and upgrades it to a write lock, there is absolutely *zero* reason to let some higher-priority process get the write-lock first - that's just simply semantically wrong bullshit. "Higher priority" does not mean "can punch through locks". Removing the silly incorrect counts should be trivial too. There really are not very many users, and they can just walk the list instead. Now, if you've found other more fundamental bugs that look unfixable, then that might mean that reverting it all is unavoidable, but.. Linus --001a113f2aa63398f7050f3daf23 Content-Type: text/plain; charset=US-ASCII; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i68jpnx60 IGZzL2xvY2tzLmMgfCAyMiArKysrKysrLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg NyBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9mcy9sb2Nrcy5j IGIvZnMvbG9ja3MuYwppbmRleCA0NzUzMjE4ZjMwOGUuLjhmYmY4MTQyOTYwOCAxMDA2NDQKLS0t IGEvZnMvbG9ja3MuYworKysgYi9mcy9sb2Nrcy5jCkBAIC04NjcsMTIgKzg2NywxMSBAQCBzdGF0 aWMgaW50IHBvc2l4X2xvY2tzX2RlYWRsb2NrKHN0cnVjdCBmaWxlX2xvY2sgKmNhbGxlcl9mbCwK ICAqLwogc3RhdGljIGludCBmbG9ja19sb2NrX2ZpbGUoc3RydWN0IGZpbGUgKmZpbHAsIHN0cnVj dCBmaWxlX2xvY2sgKnJlcXVlc3QpCiB7Ci0Jc3RydWN0IGZpbGVfbG9jayAqbmV3X2ZsID0gTlVM TDsKKwlzdHJ1Y3QgZmlsZV9sb2NrICpuZXdfZmwgPSBOVUxMLCAqb2xkX2ZsID0gTlVMTDsKIAlz dHJ1Y3QgZmlsZV9sb2NrICpmbDsKIAlzdHJ1Y3QgZmlsZV9sb2NrX2NvbnRleHQgKmN0eDsKIAlz dHJ1Y3QgaW5vZGUgKmlub2RlID0gZmlsZV9pbm9kZShmaWxwKTsKIAlpbnQgZXJyb3IgPSAwOwot CWJvb2wgZm91bmQgPSBmYWxzZTsKIAlMSVNUX0hFQUQoZGlzcG9zZSk7CiAKIAljdHggPSBsb2Nr c19nZXRfbG9ja19jb250ZXh0KGlub2RlKTsKQEAgLTg5NCwyNyArODkzLDE4IEBAIHN0YXRpYyBp bnQgZmxvY2tfbG9ja19maWxlKHN0cnVjdCBmaWxlICpmaWxwLCBzdHJ1Y3QgZmlsZV9sb2NrICpy ZXF1ZXN0KQogCQkJY29udGludWU7CiAJCWlmIChyZXF1ZXN0LT5mbF90eXBlID09IGZsLT5mbF90 eXBlKQogCQkJZ290byBvdXQ7Ci0JCWZvdW5kID0gdHJ1ZTsKLQkJbG9ja3NfZGVsZXRlX2xvY2tf Y3R4KGZsLCAmY3R4LT5mbGNfZmxvY2tfY250LCAmZGlzcG9zZSk7CisJCW9sZF9mbCA9IE5VTEw7 CiAJCWJyZWFrOwogCX0KIAogCWlmIChyZXF1ZXN0LT5mbF90eXBlID09IEZfVU5MQ0spIHsKLQkJ aWYgKChyZXF1ZXN0LT5mbF9mbGFncyAmIEZMX0VYSVNUUykgJiYgIWZvdW5kKQorCQlpZiAob2xk X2ZsKQorCQkJbG9ja3NfZGVsZXRlX2xvY2tfY3R4KG9sZF9mbCwgJmN0eC0+ZmxjX2Zsb2NrX2Nu dCwgJmRpc3Bvc2UpOworCQllbHNlIGlmIChyZXF1ZXN0LT5mbF9mbGFncyAmIEZMX0VYSVNUUykK IAkJCWVycm9yID0gLUVOT0VOVDsKIAkJZ290byBvdXQ7CiAJfQogCi0JLyoKLQkgKiBJZiBhIGhp Z2hlci1wcmlvcml0eSBwcm9jZXNzIHdhcyBibG9ja2VkIG9uIHRoZSBvbGQgZmlsZSBsb2NrLAot CSAqIGdpdmUgaXQgdGhlIG9wcG9ydHVuaXR5IHRvIGxvY2sgdGhlIGZpbGUuCi0JICovCi0JaWYg KGZvdW5kKSB7Ci0JCXNwaW5fdW5sb2NrKCZjdHgtPmZsY19sb2NrKTsKLQkJY29uZF9yZXNjaGVk KCk7Ci0JCXNwaW5fbG9jaygmY3R4LT5mbGNfbG9jayk7Ci0JfQotCiBmaW5kX2NvbmZsaWN0Ogog CWxpc3RfZm9yX2VhY2hfZW50cnkoZmwsICZjdHgtPmZsY19mbG9jaywgZmxfbGlzdCkgewogCQlp ZiAoIWZsb2NrX2xvY2tzX2NvbmZsaWN0KHJlcXVlc3QsIGZsKSkKQEAgLTkyOCw2ICs5MTgsOCBA QCBmaW5kX2NvbmZsaWN0OgogCX0KIAlpZiAocmVxdWVzdC0+ZmxfZmxhZ3MgJiBGTF9BQ0NFU1Mp CiAJCWdvdG8gb3V0OworCWlmIChvbGRfZmwpCisJCWxvY2tzX2RlbGV0ZV9sb2NrX2N0eChvbGRf ZmwsICZjdHgtPmZsY19mbG9ja19jbnQsICZkaXNwb3NlKTsKIAlsb2Nrc19jb3B5X2xvY2sobmV3 X2ZsLCByZXF1ZXN0KTsKIAlsb2Nrc19pbnNlcnRfbG9ja19jdHgobmV3X2ZsLCAmY3R4LT5mbGNf ZmxvY2tfY250LCAmY3R4LT5mbGNfZmxvY2spOwogCW5ld19mbCA9IE5VTEw7Cg== --001a113f2aa63398f7050f3daf23-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/