Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751575AbbBQBmD (ORCPT ); Mon, 16 Feb 2015 20:42:03 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:44080 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbbBQBmA (ORCPT ); Mon, 16 Feb 2015 20:42:00 -0500 Message-ID: <54E29C64.2090704@gmail.com> Date: Tue, 17 Feb 2015 09:41:56 +0800 From: Peter Hung User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Greg KH CC: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH V6 03/10] USB: f81232: implement RX bulk-in ep References: <1424073482-18164-1-git-send-email-hpeter+linux_kernel@gmail.com> <1424073482-18164-4-git-send-email-hpeter+linux_kernel@gmail.com> <20150216194115.GB9296@kroah.com> In-Reply-To: <20150216194115.GB9296@kroah.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 20 Hello, Greg KH 於 2015/2/17 上午 03:41 寫道: >> + if (unlikely(data[i+0] & UART_LSR_BRK_ERROR_BITS)) { > > Never use unlikely() unless you can prove that it actually matters if > you use it. Hint, it's almost impossible to prove, so don't use it, the > compiler and processor look-ahead is almost smarter than we are. Thanks for your hint. I'll remove it with next patch. -- With Best Regards, Peter Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/