Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756071AbbBQEEu (ORCPT ); Mon, 16 Feb 2015 23:04:50 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:46363 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755152AbbBQEEs (ORCPT ); Mon, 16 Feb 2015 23:04:48 -0500 Message-ID: <54E2BDA1.3040003@linux.vnet.ibm.com> Date: Tue, 17 Feb 2015 09:33:45 +0530 From: Preeti U Murthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Peter Zijlstra , linux-kernel@vger.kernel.org, mingo@kernel.org, rjw@rjwysocki.net, tglx@linutronix.de Subject: Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting References: <20150216121435.203983131@infradead.org> <20150216122413.880378334@infradead.org> In-Reply-To: <20150216122413.880378334@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15021704-8236-0000-0000-0000097E841A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 23 On 02/16/2015 05:45 PM, Peter Zijlstra wrote: >> From: Thomas Gleixner >> @@ -428,7 +428,7 @@ static int __ref _cpu_down(unsigned int >> __cpu_die(cpu); >> >> /* CPU is completely dead: tell everyone. Too late to complain. */ >>- tick_cleanup_dead_cpu(cpu); >>+ tick_takeover(cpu); Why is tick_handover() called after __cpu_die()? And the function tick_takeover() is not introduced until the next patch. tick_broadcast_takeover_bc() is the function used instead in this patch. Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/