Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756097AbbBQHV4 (ORCPT ); Tue, 17 Feb 2015 02:21:56 -0500 Received: from mail.dev.rtsoft.ru ([213.79.90.226]:35186 "EHLO dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbbBQHVz (ORCPT ); Tue, 17 Feb 2015 02:21:55 -0500 X-Greylist: delayed 1468 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 Feb 2015 02:21:55 EST Message-ID: <54E2E654.3010605@dev.rtsoft.ru> Date: Tue, 17 Feb 2015 09:57:24 +0300 From: Nikita Yushchenko Organization: RTSoft Software Development Center User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: linuxppc-dev@lists.ozlabs.org CC: "linux-kernel@vger.kernel.org" , "'Alexey Lugovskoy'" Subject: powerpc: fsl,pq2-localbus is broken for ages Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 25 Hi arch/powerpc/sysdev/fsl_lbc.c driver claims that it is compatible with fsl,pq2-localbus and fsl,pq2pro-localbus arch/powerpc/sysdev/fsl_lbc.c driver requires irq configured in device tree since very old times (commit 3ab8f2a2 from 2.6.37 times) None of in-tree dts files that have either fsl,pq2-localbus or fsl,pq2pro-localbus, ever defined irq for that. As far as I understand, that hardware did not have an irq. This leads to problems running recent kernels on legacy Freescale boards. I don't know if support for legacy boards worths fixing. Especially since nobody cared for years. But maybe at least remove these "compatible" lines from the drivers (and perhaps completely remove broken support for pq2 boards at all)? Nikita -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/