Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933321AbbBQJCt (ORCPT ); Tue, 17 Feb 2015 04:02:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41055 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933024AbbBQJCq (ORCPT ); Tue, 17 Feb 2015 04:02:46 -0500 Date: Tue, 17 Feb 2015 10:02:42 +0100 From: "Michael S. Tsirkin" To: Igor Mammedov Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH] vhost: support upto 509 memory regions Message-ID: <20150217090242.GA20254@redhat.com> References: <1423842599-5174-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423842599-5174-1-git-send-email-imammedo@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 46 On Fri, Feb 13, 2015 at 03:49:59PM +0000, Igor Mammedov wrote: > since commit > 1d4e7e3 kvm: x86: increase user memory slots to 509 > > it became possible to use a bigger amount of memory > slots, which is used by memory hotplug for > registering hotplugged memory. > However QEMU aborts if it's used with more than ~60 > pc-dimm devices and vhost-net since host kernel > in module vhost-net refuses to accept more than 65 > memory regions. > > Increasing VHOST_MEMORY_MAX_NREGIONS from 65 to 509 > to match KVM_USER_MEM_SLOTS fixes issue for vhost-net. > > Signed-off-by: Igor Mammedov This scares me a bit: each region is 32byte, we are talking a 16K allocation that userspace can trigger. How does kvm handle this issue? > --- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 2ee2826..ecbd7a4 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -29,7 +29,7 @@ > #include "vhost.h" > > enum { > - VHOST_MEMORY_MAX_NREGIONS = 64, > + VHOST_MEMORY_MAX_NREGIONS = 509, > VHOST_MEMORY_F_LOG = 0x1, > }; > > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/