Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933420AbbBQJQO (ORCPT ); Tue, 17 Feb 2015 04:16:14 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:63280 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933397AbbBQJQM (ORCPT ); Tue, 17 Feb 2015 04:16:12 -0500 From: Arnd Bergmann To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 34/45] include/uapi/asm-generic/signal.h: hide sigset_t definition in userspace Date: Tue, 17 Feb 2015 10:16:09 +0100 Message-ID: <2741317.tcRFXAy9C6@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1424127948-22484-35-git-send-email-mikko.rapeli@iki.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-35-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:IRy9gpzuTslEUqQgLva+ud+AqVJCoQL+zdwf3tTdHCmYS/rWeyB YjXCyCLteAyEicAmfNTpIvYWg2A1Gwjed1914+WdOHRCoHh+ll/wiRwRrf4BCmwNr3JqHvv RNSU5Ahz6tE8E+rStbkDiBiLnATx4Eu6S8PXb1xk0crnYywyVnTWsaJ/B4GmwS+D+VEqLDZ ATCtKiU9sFqcD7wY5jiVQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 20 On Tuesday 17 February 2015 00:05:37 Mikko Rapeli wrote: > +#ifdef __KERNEL__ > +/* already defined in userspace via stdlib.h */ > typedef struct { > unsigned long sig[_NSIG_WORDS]; > } sigset_t; > +#endif /* __KERNEL__ */ I'm not sure here: Is this structure always identical to the one we see in user space? If not, we might want to rename the typedef to __kernel_sigset_t instead and use that inside of the uapi headers. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/