Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933633AbbBQKYN (ORCPT ); Tue, 17 Feb 2015 05:24:13 -0500 Received: from down.free-electrons.com ([37.187.137.238]:33345 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755000AbbBQKYM (ORCPT ); Tue, 17 Feb 2015 05:24:12 -0500 Date: Tue, 17 Feb 2015 11:24:11 +0100 From: Alexandre Belloni To: Wenyou Yang Cc: nicolas.ferre@atmel.com, linux@maxim.org.za, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sylvain.rochet@finsecur.com, patrice.vilchez@atmel.com, sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com Subject: Re: [PATCH 2/3] pm: at91: pm_suspend: MOR register KEY was missing Message-ID: <20150217102411.GC11529@piout.net> References: <1423709441-8342-1-git-send-email-wenyou.yang@atmel.com> <1423709533-8416-1-git-send-email-wenyou.yang@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423709533-8416-1-git-send-email-wenyou.yang@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1526 Lines: 46 On 12/02/2015 at 10:52:13 +0800, Wenyou Yang wrote : > From: Patrice Vilchez > > Because writing the MOR register requires the PASSWD(0x37), > if missed, the write operation will be aborted. > > Signed-off-by: Patrice Vilchez Acked-by: Alexandre Belloni > --- > arch/arm/mach-at91/pm_suspend.S | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index 1c7256a..5347ad4 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -132,6 +132,7 @@ ENTRY(at91_pm_suspend_in_sram) > /* Turn off the main oscillator */ > ldr tmp1, [pmc, #AT91_CKGR_MOR] > bic tmp1, tmp1, #AT91_PMC_MOSCEN > + orr tmp1, tmp1, #AT91_PMC_KEY > str tmp1, [pmc, #AT91_CKGR_MOR] > > skip_disable_main_clock: > @@ -149,6 +150,7 @@ skip_disable_main_clock: > /* Turn on the main oscillator */ > ldr tmp1, [pmc, #AT91_CKGR_MOR] > orr tmp1, tmp1, #AT91_PMC_MOSCEN > + orr tmp1, tmp1, #AT91_PMC_KEY > str tmp1, [pmc, #AT91_CKGR_MOR] > > wait_moscrdy > -- > 1.7.9.5 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/