Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648AbbBQMVt (ORCPT ); Tue, 17 Feb 2015 07:21:49 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:38797 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829AbbBQMVq (ORCPT ); Tue, 17 Feb 2015 07:21:46 -0500 MIME-Version: 1.0 In-Reply-To: <54E32E11.9060004@xs4all.nl> References: <1424170934-18619-1-git-send-email-ricardo.ribalda@gmail.com> <54E32E11.9060004@xs4all.nl> From: Ricardo Ribalda Delgado Date: Tue, 17 Feb 2015 13:21:24 +0100 Message-ID: Subject: Re: [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls To: Hans Verkuil Cc: Hans Verkuil , Mauro Carvalho Chehab , Sylwester Nawrocki , Antti Palosaari , Sakari Ailus , linux-media , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 41 Hello Hans On Tue, Feb 17, 2015 at 1:03 PM, Hans Verkuil wrote: > Should be done after the 'ctrl == NULL' check. Good catch. Fixed on v2 > >> >> if (ctrl == NULL) >> continue; >> > > There is one more change that has to be made: setting a volatile control > should never generate a V4L2_EVENT_CTRL_CH_VALUE event since that makes > no sense. The way to prevent that is to ensure that ctrl->has_changed is > always false for volatile controls. The new_to_cur function looks at that > field to decide whether to send an event. > > The documentation should also be updated: that of V4L2_CTRL_FLAG_VOLATILE > (in VIDIOC_QUERYCTRL), and of V4L2_EVENT_CTRL_CH_VALUE. I can do this also if you want. It has been a while without contributing to media :) Regards! > > Regards, > > Hans -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/