Message-id: <1424178483.19861.1.camel@AMDC1943>
Subject: Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Kukjin Kim <kgene@kernel.org>, Olof Johansson <olof@lixom.net>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Andreas Faerber <afaerber@suse.de>, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Tue, 17 Feb 2015 14:08:03 +0100
In-reply-to: <54E33A79.3060904@collabora.co.uk>
References: <1424173109-30347-1-git-send-email-javier.martinez@collabora.co.uk>
 <1424175623.14482.4.camel@AMDC1943> <54E33A79.3060904@collabora.co.uk>
Content-type: text/plain; charset=UTF-8
MIME-version: 1.0
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1908
Lines: 48

On wto, 2015-02-17 at 13:56 +0100, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 02/17/2015 01:20 PM, Krzysztof Kozlowski wrote:
> > On wto, 2015-02-17 at 12:38 +0100, Javier Martinez Canillas wrote:
> >> Enabling Exynos DRM IOMMU support for Exynos is currently broken and
> >> causes a BUG on exynos-iommu driver. This was not an issue since the
> >> options was disabled in exynos_defconfig but after commit 8dcc14f82f06
> >> ("drm/exynos: IOMMU support should not be selectable by user"), it is
> >> selected if EXYNOS_IOMMU is enabled which is in exynos_defconfig.
> >> 
> >> So a kernel built using exynos_defconfig after the mentioned commit
> >> fails to boot [0]. Disable IOMMU support in Exynos defconfig until
> >> things get sorted out.
> > 
> > On which board you got this error?
> > 
> 
> Sorry, I should had mention it in the commit message. I get that error
> with at least Exynos5800 Peach Pi, Exynos5420 Peach Pit and Exynos5250
> Snow Chromebooks with today's next (next-20150217).
> 
> The problem is that the Exynos IOMMU driver does not set a struct
> exynos_iommu_owner in dev.archdata.iommu but __exynos_sysmmu_enable()
> has a BUG_ON(!has_sysmmu(dev)).
> 
> Marek's series [1] solves this issue by filling sysmmu devices from DT
> but causes boot failures on the Exynos Chromebooks because the display
> is left enabled by the bootloader [2].
> 
> So I think that this option should be disabled until is known to not
> cause issues on any platform.

Sure, I am completely fine with that change. I just wanted to know the
hardware.

Anyway Marek already acked this I won't duplicate the effort :).

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/