Message-ID: <54E33F7F.8020201@suse.cz>
Date: Tue, 17 Feb 2015 14:17:51 +0100
From: Michal Marek <mmarek@suse.cz>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Mikko Rapeli <mikko.rapeli@iki.fi>, linux-kernel@vger.kernel.org
CC: Andrew Morton <akpm@linux-foundation.org>,
        Javier Barrio <javier.barrio.mart@gmail.com>
Subject: Re: [PATCH 03/45] headers_install.sh: enhance error handling
References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-4-git-send-email-mikko.rapeli@iki.fi>
In-Reply-To: <1424127948-22484-4-git-send-email-mikko.rapeli@iki.fi>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 33

On 2015-02-17 00:05, Mikko Rapeli wrote:
> Exit with error if using undefined variables or if any sub command fails
> with error return value. unidef needs special handling since but this can
> be done without the trap. Enables exaniming intermediate files if some
> commands failed.

The intermediate files are removed by your patch as well, aren't they?
Actually, I don't see any change in behavior after your patch.


> Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
> ---
>  scripts/headers_install.sh | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> index fdebd66..072f7d3 100755
> --- a/scripts/headers_install.sh
> +++ b/scripts/headers_install.sh
> @@ -1,4 +1,7 @@
>  #!/bin/sh
> +set -e
> +set -u
> +#set -x

The commented-out statement should be removed.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/