Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755188AbbBQNdt (ORCPT ); Tue, 17 Feb 2015 08:33:49 -0500 Received: from mail-yk0-f169.google.com ([209.85.160.169]:32913 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754957AbbBQNds (ORCPT ); Tue, 17 Feb 2015 08:33:48 -0500 MIME-Version: 1.0 X-Originating-IP: [77.108.99.100] In-Reply-To: <1424169226-30112-1-git-send-email-al.drozdov@gmail.com> References: <1424169226-30112-1-git-send-email-al.drozdov@gmail.com> Date: Tue, 17 Feb 2015 17:33:47 +0400 Message-ID: Subject: Re: [PATCH] ipv4: ip_check_defrag should correctly check return value of skb_copy_bits From: Denis Kirjanov To: Alexander Drozdov Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1496 Lines: 43 On 2/17/15, Alexander Drozdov wrote: > skb_copy_bits() returns zero on success and negative value on error, > so it is needed to invert the condition in ip_check_defrag(). > Nice. Grepping through the net directory shows that the skb_copy_bits() return value is completely ignored in net/wireless/util.c > Fixes: 1bf3751ec90c ("ipv4: ip_check_defrag must not modify skb before > unsharing") > Signed-off-by: Alexander Drozdov > --- > net/ipv4/ip_fragment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c > index e5b6d0d..2c8d98e 100644 > --- a/net/ipv4/ip_fragment.c > +++ b/net/ipv4/ip_fragment.c > @@ -664,7 +664,7 @@ struct sk_buff *ip_check_defrag(struct sk_buff *skb, u32 > user) > if (skb->protocol != htons(ETH_P_IP)) > return skb; > > - if (!skb_copy_bits(skb, 0, &iph, sizeof(iph))) > + if (skb_copy_bits(skb, 0, &iph, sizeof(iph)) < 0) > return skb; > > if (iph.ihl < 5 || iph.version != 4) > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/