Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755018AbbBQS1y (ORCPT ); Tue, 17 Feb 2015 13:27:54 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:33093 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbbBQS1v (ORCPT ); Tue, 17 Feb 2015 13:27:51 -0500 Message-ID: <54E387BF.6010909@oracle.com> Date: Tue, 17 Feb 2015 13:26:07 -0500 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Raghavendra K T CC: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, peterz@infradead.org, torvalds@linux-foundation.org, konrad.wilk@oracle.com, pbonzini@redhat.com, paulmck@linux.vnet.ibm.com, waiman.long@hp.com, davej@redhat.com, oleg@redhat.com, x86@kernel.org, jeremy@goop.org, paul.gortmaker@windriver.com, ak@linux.intel.com, jasowang@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, riel@redhat.com, borntraeger@de.ibm.com, akpm@linux-foundation.org, a.ryabinin@samsung.com, dave@stgolabs.net Subject: Re: [PATCH V5] x86 spinlock: Fix memory corruption on completing completions References: <1423979744-18320-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <54E03652.8010104@linux.vnet.ibm.com> In-Reply-To: <54E03652.8010104@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3008 Lines: 72 On 02/15/2015 01:01 AM, Raghavendra K T wrote: > On 02/15/2015 11:25 AM, Raghavendra K T wrote: >> Paravirt spinlock clears slowpath flag after doing unlock. >> As explained by Linus currently it does: >> prev = *lock; >> add_smp(&lock->tickets.head, TICKET_LOCK_INC); >> >> /* add_smp() is a full mb() */ >> >> if (unlikely(lock->tickets.tail & TICKET_SLOWPATH_FLAG)) >> __ticket_unlock_slowpath(lock, prev); >> >> which is *exactly* the kind of things you cannot do with spinlocks, >> because after you've done the "add_smp()" and released the spinlock >> for the fast-path, you can't access the spinlock any more. Exactly >> because a fast-path lock might come in, and release the whole data >> structure. >> >> Linus suggested that we should not do any writes to lock after unlock(), >> and we can move slowpath clearing to fastpath lock. >> >> So this patch implements the fix with: >> 1. Moving slowpath flag to head (Oleg): >> Unlocked locks don't care about the slowpath flag; therefore we can keep >> it set after the last unlock, and clear it again on the first (try)lock. >> -- this removes the write after unlock. note that keeping slowpath flag would >> result in unnecessary kicks. >> By moving the slowpath flag from the tail to the head ticket we also avoid >> the need to access both the head and tail tickets on unlock. >> >> 2. use xadd to avoid read/write after unlock that checks the need for >> unlock_kick (Linus): >> We further avoid the need for a read-after-release by using xadd; >> the prev head value will include the slowpath flag and indicate if we >> need to do PV kicking of suspended spinners -- on modern chips xadd >> isn't (much) more expensive than an add + load. >> >> Result: >> setup: 16core (32 cpu +ht sandy bridge 8GB 16vcpu guest) >> benchmark overcommit %improve >> kernbench 1x -0.13 >> kernbench 2x 0.02 >> dbench 1x -1.77 >> dbench 2x -0.63 >> >> [Jeremy: hinted missing TICKET_LOCK_INC for kick] >> [Oleg: Moving slowpath flag to head, ticket_equals idea] >> [PeterZ: Detailed changelog] >> >> Reported-by: Sasha Levin >> Suggested-by: Linus Torvalds >> Signed-off-by: Raghavendra K T >> --- > > Sasha, Hope this addresses invalid read concern you had with latest > xadd based implementation. > > (Think we need to test without Oleg's PATCH] sched/completion: completion_done() should serialize with complete() reported by Paul.) > I ran it for a while and everything seems to work correctly: Tested-by: Sasha Levin Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/