Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753735AbbBQT7Y (ORCPT ); Tue, 17 Feb 2015 14:59:24 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:40060 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbbBQT7W (ORCPT ); Tue, 17 Feb 2015 14:59:22 -0500 X-IronPort-AV: E=Sophos;i="5.09,595,1418112000"; d="scan'208";a="57205648" Message-ID: <54E39DF1.50409@broadcom.com> Date: Tue, 17 Feb 2015 12:00:49 -0800 From: Arun Ramamurthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Arnd Bergmann CC: Kishon Vijay Abraham I , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , , Jonathan Richardson , Scott Branden , Ray Jui , , , , Dmitry Torokhov , Anatol Pomazau Subject: Re: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver References: <1424200821-16368-1-git-send-email-arun.ramamurthy@broadcom.com> <1424200821-16368-2-git-send-email-arun.ramamurthy@broadcom.com> <8242260.cl4QTECoeX@wuerfel> In-Reply-To: <8242260.cl4QTECoeX@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 42 Thank you for the review Arnd. On 15-02-17 11:41 AM, Arnd Bergmann wrote: > On Tuesday 17 February 2015 11:20:20 Arun Ramamurthy wrote: >> + /* This nodes declares port 0 >> + and port 1 as host*/ >> + >> + ehci0: usb@0x18048000 { >> + compatible = "generic-ehci"; >> + reg = <0x18048000 0x100>; >> + interrupts = ; >> + phys = <&usbphy0 0 1 &usbphy0 1>; > > The second reference in the example is missing the last cell, > as you have #phy-cells = <2>. > I am missing a 1 for the port number, will update in next patchset, thank you >> + phy-names = "usbp0","usbp1"; >> + status = "okay"; >> + }; > > Further, the binding for "generic-ehci" requires the name to be "usb", > not "usbp0". You should probably update that binding if you can have > multiple references to mention that. > > Can you make both names "usb"? If not, we should document a common > naming scheme that the driver can use. > Arnd, I patched the ehci and ohci driver to accept multiple phys so they require different names and cannot both be "usb". That patch was accepted by Alen Stern but I did not update the bindings documentation. I will send out another patch for that. Could we go with the naming scheme of "usb" + "p" + port number or do you have other suggestions? > Arnd > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/