Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754554AbbBQUUX (ORCPT ); Tue, 17 Feb 2015 15:20:23 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:57712 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbbBQUUV (ORCPT ); Tue, 17 Feb 2015 15:20:21 -0500 MIME-Version: 1.0 In-Reply-To: References: <1424177190-14252-1-git-send-email-jeff.layton@primarydata.com> Date: Tue, 17 Feb 2015 12:20:20 -0800 X-Google-Sender-Auth: gsKR8GrP5Ck2tLVR0rY2f1MG-t4 Message-ID: Subject: Re: [PATCH 0/4] locks: flock and lease related bugfixes, and remove i_flctx counters From: Linus Torvalds To: Jeff Layton Cc: linux-fsdevel , Linux Kernel Mailing List , "Kirill A. Shutemov" , "J. Bruce Fields" , Christoph Hellwig , Dave Chinner , Sasha Levin Content-Type: multipart/mixed; boundary=047d7bdc79e48fa628050f4e6e12 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2727 Lines: 57 --047d7bdc79e48fa628050f4e6e12 Content-Type: text/plain; charset=UTF-8 On Tue, Feb 17, 2015 at 11:55 AM, Linus Torvalds wrote: > > I do believe that we should add a "list_count()" function, so that we could write > > *flock_count = list_count(&ctx->flc_flock); > > instead of that horribly ugly > > list_for_each_entry(lock, &ctx->flc_flock, fl_list) > ++(*flock_count); > > thing. But that's a separate cleanup. The helper function would possibly be something like this. Untested. It may mix-count, or it might do unspeakable acts on your pets. No guarantees. Linus --047d7bdc79e48fa628050f4e6e12 Content-Type: text/plain; charset=US-ASCII; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i69qjcm30 IGluY2x1ZGUvbGludXgvbGlzdC5oIHwgMjggKysrKysrKysrKysrKysrKysrKysrKysrKysrKwog MSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xp bnV4L2xpc3QuaCBiL2luY2x1ZGUvbGludXgvbGlzdC5oCmluZGV4IGZlYjc3M2M3NmVlMC4uNDk1 NTY2YmUwMmUxIDEwMDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L2xpc3QuaAorKysgYi9pbmNsdWRl L2xpbnV4L2xpc3QuaApAQCAtMTkwLDYgKzE5MCwyMCBAQCBzdGF0aWMgaW5saW5lIGludCBsaXN0 X2VtcHR5KGNvbnN0IHN0cnVjdCBsaXN0X2hlYWQgKmhlYWQpCiB9CiAKIC8qKgorICogbGlzdF9j b3VudCAtIGNvdW50IG51bWJlciBvZiBlbnRyaWVzIG9uIGxpc3QKKyAqIEBoZWFkOiB0aGUgbGlz dCB0byBjb3VudC4KKyAqLworc3RhdGljIGlubGluZSBpbnQgbGlzdF9jb3VudChjb25zdCBzdHJ1 Y3QgbGlzdF9oZWFkICpoZWFkKQoreworCWludCBsZW4gPSAwOworCWNvbnN0IHN0cnVjdCBsaXN0 X2hlYWQgKnAgPSBoZWFkOworCisJd2hpbGUgKChwID0gcC0+bmV4dCkgIT0gaGVhZCkKKwkJbGVu Kys7CisJcmV0dXJuIGxlbjsKK30KKworLyoqCiAgKiBsaXN0X2VtcHR5X2NhcmVmdWwgLSB0ZXN0 cyB3aGV0aGVyIGEgbGlzdCBpcyBlbXB0eSBhbmQgbm90IGJlaW5nIG1vZGlmaWVkCiAgKiBAaGVh ZDogdGhlIGxpc3QgdG8gdGVzdAogICoKQEAgLTYxMSw2ICs2MjUsMjAgQEAgc3RhdGljIGlubGlu ZSBpbnQgaGxpc3RfZW1wdHkoY29uc3Qgc3RydWN0IGhsaXN0X2hlYWQgKmgpCiAJcmV0dXJuICFo LT5maXJzdDsKIH0KIAorLyoqCisgKiBobGlzdF9jb3VudCAtIGNvdW50IG51bWJlciBvZiBlbnRy aWVzIG9uIGhsaXN0CisgKiBAaGVhZDogdGhlIGxpc3QgdG8gY291bnQuCisgKi8KK3N0YXRpYyBp bmxpbmUgaW50IGhsaXN0X2NvdW50KGNvbnN0IHN0cnVjdCBobGlzdF9oZWFkICpoZWFkKQorewor CWludCBsZW4gPSAwOworCWNvbnN0IHN0cnVjdCBobGlzdF9ub2RlICpwOworCisJZm9yIChwID0g aGVhZC0+Zmlyc3Q7IHA7IHAgPSBwLT5uZXh0KQorCQlsZW4rKzsKKwlyZXR1cm4gbGVuOworfQor CiBzdGF0aWMgaW5saW5lIHZvaWQgX19obGlzdF9kZWwoc3RydWN0IGhsaXN0X25vZGUgKm4pCiB7 CiAJc3RydWN0IGhsaXN0X25vZGUgKm5leHQgPSBuLT5uZXh0Owo= --047d7bdc79e48fa628050f4e6e12-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/