Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbbBQUYn (ORCPT ); Tue, 17 Feb 2015 15:24:43 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:44564 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbbBQUYl (ORCPT ); Tue, 17 Feb 2015 15:24:41 -0500 MIME-Version: 1.0 In-Reply-To: References: <1424041083-23694-1-git-send-email-ruslan.bilovol@gmail.com> Date: Tue, 17 Feb 2015 22:24:40 +0200 Message-ID: Subject: Re: [PATCH v2 0/2] usb/gadget: independent registration of gadgets and gadget From: Ruslan Bilovol To: Alan Stern Cc: "Balbi, Felipe" , Krzysztof Opasiak , Peter Chen , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , Andrzej Pietrasiewicz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 41 Hi Alan, On Mon, Feb 16, 2015 at 1:04 AM, Alan Stern wrote: > On Mon, 16 Feb 2015, Ruslan Bilovol wrote: > >> This patchset adds independent registration of gadgets >> and gadget drivers to udc-core. This is very useful for >> built-in modules into kernel case since it's possible >> situation that gadget driver is probing at a time >> when no gadgets are registered in udc-core. >> In this case instead of silently failing without >> of any attempt to recover, with independent registration >> of gadgets and gadget drivers there is no matter >> in which order gadgets and gadget drivers are >> probed/registered. >> >> This patch has side-effect on gadget drivers that had >> __init/__exit attributes on some paths like bind/unbind >> and (since bind/unbind may happen at any time) should >> not use them now. This is covered by second patch >> (please let me know if I need to break it into separate >> patches for each gadget driver) > > The two patches should be in the opposite order. Otherwise someone > might apply the first patch but not the second, and then the gadget > drivers would crash when their bind/unbind routines were called at the > wrong time. Agree, this will be done in v3 patch set. Best regards, Ruslan > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/