Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbbBQWUt (ORCPT ); Tue, 17 Feb 2015 17:20:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36886 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbbBQWUs (ORCPT ); Tue, 17 Feb 2015 17:20:48 -0500 Date: Tue, 17 Feb 2015 14:20:45 -0800 From: Greg Kroah-Hartman To: Davidlohr Bueso Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err Message-ID: <20150217222045.GB27762@kroah.com> References: <1424210254.2046.105.camel@stgolabs.net> <20150217220246.GA25711@kroah.com> <1424210959.2046.107.camel@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424210959.2046.107.camel@stgolabs.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1722 Lines: 39 On Tue, Feb 17, 2015 at 02:09:19PM -0800, Davidlohr Bueso wrote: > On Tue, 2015-02-17 at 14:02 -0800, Greg Kroah-Hartman wrote: > > On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote: > > > As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast()) > > > we no longer call get_user_pages(), thus update the warning. > > > > > > Signed-off-by: Davidlohr Bueso > > > --- > > > drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c > > > index 35f19a6..1d80c56 100644 > > > --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c > > > +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c > > > @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva, > > > produce_q->kernel_if->num_pages, 1, > > > produce_q->kernel_if->u.h.header_page); > > > if (retval < produce_q->kernel_if->num_pages) { > > > - pr_warn("get_user_pages(produce) failed (retval=%d)", retval); > > > + pr_warn("get_user_pages_fast(produce) failed (retval=%d)", > > > + retval); > > > > What can a user do with this message? Shouldn't it be a debug message? > > I was trying to be as least invasive as possible, as I zero knowledge of > this thingie. But yes, such a message does seem more appropriate as > pr_debug(). Do you want me to respin? Please do. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/