Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbBQWYz (ORCPT ); Tue, 17 Feb 2015 17:24:55 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34850 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbbBQWYx (ORCPT ); Tue, 17 Feb 2015 17:24:53 -0500 Message-ID: <54E3BFB3.5030801@codeaurora.org> Date: Tue, 17 Feb 2015 14:24:51 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org CC: Kyungmin Park , Marek Szyprowski , stable@vger.kernel.org Subject: Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency References: <1424093802-5488-1-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1424093802-5488-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 27 On 02/16/15 05:36, Krzysztof Kozlowski wrote: > During CPU shutdown the exynos_cpu_power_down() is called after > disabling cache coherency and it uses LDREX and STREX instructions (by > calling of_machine_is_compatible() -> kobject_get() -> kref_get()). > > The LDREX and STREX should not be used after disabling the cache > coherency so just use soc_is_exynos(). > > Signed-off-by: Krzysztof Kozlowski > Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420") > Cc: > Reported-by: Stephen Boyd > --- Looks good to me. Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/