Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753061AbbBQXLp (ORCPT ); Tue, 17 Feb 2015 18:11:45 -0500 Received: from mail-qg0-f53.google.com ([209.85.192.53]:52307 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbbBQXLn (ORCPT ); Tue, 17 Feb 2015 18:11:43 -0500 From: David Long To: linux-arm-kernel@lists.infradead.org, Russell King Cc: Sandeepa Prabhu , William Cohen , Steve Capper , Catalin Marinas , Will Deacon , "Jon Medhurst (Tixy)" , Masami Hiramatsu , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , , linux-kernel@vger.kernel.org Subject: [PATCH v5 0/6] arm64: Add kernel probes (kprobes) support Date: Tue, 17 Feb 2015 18:11:35 -0500 Message-Id: <1424214701-4899-1-git-send-email-dave.long@linaro.org> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4066 Lines: 94 From: "David A. Long" This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches, first seen in October 2013. This version attempts to address concerns raised by reviewers and also fixes problems discovered during testing, particularly during SMP testing. This patchset adds support for kernel probes(kprobes), jump probes(jprobes) and return probes(kretprobes) support for ARM64. The kprobes mechanism makes use of software breakpoint and single stepping support available in the ARM v8 kernel. Changes since v2 include: 1) Removal of NOP padding in kprobe XOL slots. Slots are now exactly one instruction long. 2) Disabling of interrupts during execution in single-step mode. 3) Fixing of numerous problems in instruction simulation code (mostly thanks to Will Cohen). 4) Support for the HAVE_REGS_AND_STACK_ACCESS_API feature is added, to allow access to kprobes through debugfs. 5) kprobes is *not* enabled in defconfig. 6) Numerous complaints from checkpatch have been cleaned up, although a couple remain as removing the function pointer typedefs results in ugly code. Changes since v3 include: 1) Remove table-driven instruction parsing and replace with an if statement calling out to old and new instruction test functions in insn.c. 2) I removed the addition of orig_x0 to ptrace.h. 3) Reorder the patches. 4) Replace the previous interrupt disabling (from Will Cohen) with an improved solution (from Steve Capper). Changes since v4 include: 1) Added insn.c functions to detect exception instructions and DAIF read/write instructions, and use them to reject probing same. 2) Changed adr detect function to also recognize adrp. Reject both. 3) Added missing __kprobes for some new functions. 4) Added call to kprobes_fault_handler from mm do_page_fault. 5) Reject all non-simulated branch/ret instructions, not just those that use an immediate offset. 6) Moved software breakpoint definitions into debug-monitors.h. 7) Removed "!XIP_KERNEL" from Kconfig. 8) changed kprobes_condition_check_t and kprobes_prepare_t to probes_*, for future sharing with uprobes. 9) Removed bogus call to kprobes_restore_local_irqflag() from trampoline_probe_handler(). David A. Long (2): arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature arm64: Add more test functions to insn.c Sandeepa Prabhu (4): arm64: Kprobes with single stepping support arm64: kprobes instruction simulation support arm64: Add kernel return probes support (kretprobes) kprobes: Add arm64 case in kprobe example module arch/arm64/Kconfig | 3 + arch/arm64/include/asm/debug-monitors.h | 5 + arch/arm64/include/asm/insn.h | 24 +- arch/arm64/include/asm/kprobes.h | 61 +++ arch/arm64/include/asm/probes.h | 50 +++ arch/arm64/include/asm/ptrace.h | 32 +- arch/arm64/include/uapi/asm/ptrace.h | 36 ++ arch/arm64/kernel/Makefile | 3 + arch/arm64/kernel/insn.c | 28 ++ arch/arm64/kernel/kprobes-arm64.c | 166 ++++++++ arch/arm64/kernel/kprobes-arm64.h | 30 ++ arch/arm64/kernel/kprobes.c | 690 ++++++++++++++++++++++++++++++++ arch/arm64/kernel/kprobes.h | 24 ++ arch/arm64/kernel/ptrace.c | 116 ++++++ arch/arm64/kernel/vmlinux.lds.S | 1 + arch/arm64/mm/fault.c | 25 ++ samples/kprobes/kprobe_example.c | 8 + 17 files changed, 1299 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/include/asm/kprobes.h create mode 100644 arch/arm64/include/asm/probes.h create mode 100644 arch/arm64/kernel/kprobes-arm64.c create mode 100644 arch/arm64/kernel/kprobes-arm64.h create mode 100644 arch/arm64/kernel/kprobes.c create mode 100644 arch/arm64/kernel/kprobes.h -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/