Message-ID: <1424220942.23608.76.camel@decadent.org.uk>
Subject: Re: [PATCH 3.2 082/152] virtio: use dev_to_virtio wrapper in virtio
From: Ben Hutchings <ben@decadent.org.uk>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        akpm@linux-foundation.org, "Michael S. Tsirkin" <mst@redhat.com>,
        Wanlong Gao <gaowanlong@cn.fujitsu.com>
Date: Wed, 18 Feb 2015 00:55:42 +0000
In-Reply-To: <873865t8fu.fsf@rustcorp.com.au>
References: <lsq.1424137613.17418214@decadent.org.uk>
	 <873865t8fu.fsf@rustcorp.com.au>
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-KcT4cVdTVdcRmWzrcoLx"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2272
Lines: 64


--=-KcT4cVdTVdcRmWzrcoLx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2015-02-17 at 15:56 +1030, Rusty Russell wrote:
> Ben Hutchings <ben@decadent.org.uk> writes:
> > 3.2.67-rc1 review patch.  If anyone has any objections, please let me k=
now.
>=20
> Ben, what are your criteria for putting patches into 3.2?
>=20
> This patch is a trivial cleanup.  It doesn't fix anything, but it does
> add some churn.

It fixes the definition of dev_to_virtio().

> I can see that 083 and 084 follow this, but 083 needed a backport
> anyway.

Patch 083 "virtio_pci: defer kfree until release callback" uses
dev_to_virtio(_d) which would expand to a syntax error without this.

> And it wasn't an issue we saw in Real Life (device removal
> is rare), so it wasn't CC: stable.
>=20
> 084 was a comment addition.  Backporting that just seems weird.

Nevertheless, it had 'cc: stable' and is obviously harmless.

Ben.

--=20
Ben Hutchings
To err is human; to really foul things up requires a computer.

--=-KcT4cVdTVdcRmWzrcoLx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIVAwUAVOPjE+e/yOyVhhEJAQofNRAAuMDvkD+LRokHuaw06G9iusJUDoQyrh3o
DxQHoU7FeHf23sA1OPg8xxzJji3fHcGMsLquAe/nCtC8l726k8JAQXkrMygKwSeZ
FZJnBraRh0i4EZyfO96MK1D5z/E66Dq+j3MjuvxNPrtKlDAYEv8+L/nwMLcoWuI3
snvzthPi8O7RCjDRHThYKZkFPpvMEYCSzTn+fNuje2Yq4TeulwONfWL2/zDc8XmY
tkzz5dqBvlIPst8X1dcHYi5ChqAAUY6R7ycsaGJv8P7Q4taFx++2WX3uypNAMUXV
rd/srvqN1Ew6ABQgDEFB9JOttfusrAdjj1drwB1mg12GQeUeHwvGRNzTGGh0HnZ+
sL9j0kngfBe0Ohk2Dalwq0VDog2JeyOEOaPAXVK/8cF8lsPJDhoA3xXqnFfDlmq8
2/eVpx0PqrJ2o16UgFFcuIevr2r+zCeTiWgegrmuNI0ZQYndlyXqczERw8QDXoWY
l8nxKs/s7+/PUd+++GCFMehfDjtdX6DoQJUiR0nqArS4CS6tDJZZcLDkbQPhP6a1
GanxxJFArQLu+Uc/zoUScIiOoUxCsv3PZ4ki7onEBoKugss+OxJ0HOqp08RuSTV4
/sdhGqKCH/JCZ3ZOCV/S9chRU6AI09qXjbOn7jq8gvbgQicqMlpqTjKGN1ZtZ9gD
xrnXZImoovQ=
=2v0V
-----END PGP SIGNATURE-----

--=-KcT4cVdTVdcRmWzrcoLx--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/