Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbbBRBms (ORCPT ); Tue, 17 Feb 2015 20:42:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbbBRBmr (ORCPT ); Tue, 17 Feb 2015 20:42:47 -0500 Message-ID: <1424223745.2600.5.camel@pluto.fritz.box> Subject: Re: [RFC PATCH 3/8] kmod - teach call_usermodehelper() to use a namespace From: Ian Kent To: Oleg Nesterov Cc: Kernel Mailing List , David Howells , Trond Myklebust , "J. Bruce Fields" , Benjamin Coddington , Al Viro , Jeff Layton , "Eric W. Biederman" Date: Wed, 18 Feb 2015 09:42:25 +0800 In-Reply-To: <20150216171323.GA23710@redhat.com> References: <20150205021553.8382.16297.stgit@pluto.fritz.box> <20150205023410.8382.13695.stgit@pluto.fritz.box> <20150208190019.GA22948@redhat.com> <1423446203.2583.18.camel@pluto.fritz.box> <20150209160328.GA2817@redhat.com> <1423526889.2612.14.camel@pluto.fritz.box> <20150210165503.GA6797@redhat.com> <1424067417.4134.15.camel@pluto.fritz.box> <20150216171323.GA23710@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2691 Lines: 73 On Mon, 2015-02-16 at 18:13 +0100, Oleg Nesterov wrote: > On 02/16, Ian Kent wrote: > > > > On Tue, 2015-02-10 at 17:55 +0100, Oleg Nesterov wrote: > > > On 02/10, Ian Kent wrote: > > > > > > > > On Mon, 2015-02-09 at 17:03 +0100, Oleg Nesterov wrote: > > > > > > > > > > I understand. but I still can't understand why we can't implement something > > > > > like > > > > > enter_ns(struct nsproxy *p) > > > > > { > > > > > new_nsproxy = create_new_namespaces(...); > > > > > > > > > > p->mnt_ns->ns->ops->install(new_nsproxy, ...); > > > > > p->pid_ns_for_children->ns->ops->install(new_nsproxy, ...); > > > > > ... > > > > > > > > > > switch_task_namespaces(new_nsproxy); > > > > > } > > > > > > > > > > Why we should abuse fs/proc ? > > > > > > > > That sounds like a much better approach. > > > > Your saying just take a reference to the nsproxy from the located > > > > process and use it instead, right? > > > > > > Yes, > > > > I'm still not sure if this can be done (at least without surgery to the > > namespace implementation) and I think I've been here before which is > > what lead to the file_open_root() approach. > > > > The difficulty is the second parameter to the install() call above, the > > struct ns_common. In setns() it's obtained from the procfs file inode > > and the file open is what's used to obtain each namespace type (in the > > form of a struct ns_common) from a process context different from > > current, current being the thread runner process. > > > > I might still be able to work out a (viable) way to obtain the > > appropriate ns_common struct in each case without a file open but it's > > hard to see how. > > Not sure I understand... Every "namespace" pointer "struct nsproxy" has > the "struct ns_common ns" you need? So you can do (for example) > > p->mnt_ns->ns->ops->install(new_nsproxy, &p->mnt_ns->ns); > > or I missed something? (userns differs, you need cred->user_ns, of course). I didn't see that when I looked so I missed it, thanks for pointing it out. > > > Perhaps I missed something, but this doesn't look like a problem... > > The real problem is that , let me repeat, is that pidns_install() does not > and can't change active_pid_ns. So I think that kernel_thread_in_ns() probably > make more sense. Right, I didn't miss that when you mentioned it. Changing the execution order using your kernel_thread_in_ns() suggestion is clearly what needs to be done. Ian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/