Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbbBRFoe (ORCPT ); Wed, 18 Feb 2015 00:44:34 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:41798 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbbBRFod (ORCPT ); Wed, 18 Feb 2015 00:44:33 -0500 Message-ID: <54E426B5.4070206@linaro.org> Date: Wed, 18 Feb 2015 13:44:21 +0800 From: zhangfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , balbi@ti.com, mark.rutland@arm.com, Peter Chen , Sergei Shtylyov , "dan . zhao" , Wangbinghui CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v4 4/4] phy: add phy-hi6220-usb References: <1423726646-30336-1-git-send-email-zhangfei.gao@linaro.org> <1423726646-30336-5-git-send-email-zhangfei.gao@linaro.org> <54E4249C.9050404@ti.com> In-Reply-To: <54E4249C.9050404@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 31 Hi, Kishon On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: >> Add usb phy controller for hi6220 platform >> >> Signed-off-by: Zhangfei Gao >> --- >> drivers/phy/Kconfig | 9 ++ >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-hi6220-usb.c | 306 >> +++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 316 insertions(+) >> create mode 100644 drivers/phy/phy-hi6220-usb.c > > why is this driver in drivers/phy when it doesn't use the generic PHY > framework at all? > Balbi recommended "new drivers only on drivers/phy/", including usb phy. So Move drivers/usb/phy/phy-hi6220-usb.c to drivers/phy/phy-hi6220-usb.c, required by Balbi. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/