Message-ID: <54E46FCE.6000508@suse.com>
Date: Wed, 18 Feb 2015 11:56:14 +0100
From: Juergen Gross <jgross@suse.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Andrew Cooper <andrew.cooper3@citrix.com>,
        David Vrabel <david.vrabel@citrix.com>, linux-kernel@vger.kernel.org,
        xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH 02/13] xen: anchor linear p2m list in shared
 info structure
References: <1424242326-26611-1-git-send-email-jgross@suse.com>	<1424242326-26611-3-git-send-email-jgross@suse.com>	<54E46A33.9030401@citrix.com> <54E46CB1.5010702@suse.com> <54E46E61.8030805@citrix.com>
In-Reply-To: <54E46E61.8030805@citrix.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1269
Lines: 33

On 02/18/2015 11:50 AM, Andrew Cooper wrote:
> On 18/02/15 10:42, Juergen Gross wrote:
>>
>>>>    /* Set up p2m_top to point to the domain-builder provided p2m
>>>> pages */
>>>> @@ -469,8 +473,10 @@ static pte_t *alloc_p2m_pmd(unsigned long addr,
>>>> pte_t *pte_pg)
>>>>
>>>>            ptechk = lookup_address(vaddr, &level);
>>>>            if (ptechk == pte_pg) {
>>>> +            HYPERVISOR_shared_info->arch.p2m_generation++;
>>>>                set_pmd(pmdp,
>>>>                    __pmd(__pa(pte_newpg[i]) | _KERNPG_TABLE));
>>>> +            HYPERVISOR_shared_info->arch.p2m_generation++;
>>>
>>> Do these increments of p2m_generation need to be atomic?
>>
>> Hmm, they are done under lock. I don't think the compiler is allowed to
>> reorder the writes to p2m_generation across set_pmd().
>
> They do need smp_wmb() to guarantee that the increment is visible before
> the update occurs, just as the toolstack will need smp_rmb() to read.

Okay, I'll add smp_wmb() before and after calling set_pmd().


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/