Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbbBRLG4 (ORCPT ); Wed, 18 Feb 2015 06:06:56 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:57171 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbbBRLGz (ORCPT ); Wed, 18 Feb 2015 06:06:55 -0500 From: Arnd Bergmann To: Andrew Vagin Cc: Andrey Vagin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Oleg Nesterov , Andrew Morton , Cyrill Gorcunov , Pavel Emelyanov , Roger Luethi Subject: Re: [PATCH 0/7] [RFC] kernel: add a netlink interface to get information about processes Date: Wed, 18 Feb 2015 12:06:40 +0100 Message-ID: <2631974.u59Ona1mDt@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150217213313.GB7091@paralelels.com> References: <1424161226-15176-1-git-send-email-avagin@openvz.org> <3238376.TxgiSSEfbZ@wuerfel> <20150217213313.GB7091@paralelels.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:0rG2lChv/PqAayLQzPkh7JXVllkxMufJPvEnZKqlJpMbikrJofe xZIPDy7rK9GxK71NFtERzdThcdk+wn6+anIR9b48a3lefsRohVFOzA1Z8tEAikR/N7uGyEA 8Pw4HUXlPLpD4e5TwJPfnZf0No0SpzXO221b1GEvCLd6/m46tA+Rgn55BEKbbG3ktMv6KCr qOA5HCAvqIXn2UG9gs2GA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1621 Lines: 37 On Wednesday 18 February 2015 00:33:13 Andrew Vagin wrote: > On Tue, Feb 17, 2015 at 09:53:09AM +0100, Arnd Bergmann wrote: > > On Tuesday 17 February 2015 11:20:19 Andrey Vagin wrote: > > > task_diag is based on netlink sockets and looks like socket-diag, which > > > is used to get information about sockets. > > > > > > A request is described by the task_diag_pid structure: > > > > > > struct task_diag_pid { > > > __u64 show_flags; /* specify which information are required */ > > > __u64 dump_stratagy; /* specify a group of processes */ > > > > > > __u32 pid; > > > }; > > > > Can you explain how the interface relates to the 'taskstats' genetlink > > API? Did you consider extending that interface to provide the > > information you need instead of basing on the socket-diag? > > It isn't based on the socket-diag, it looks like socket-diag. > > Current task_diag registers a new genl family, but we can use the taskstats > family and add task_diag commands to it. What I meant was more along the lines of making it look like taskstats by adding new fields to 'struct taskstat' for what you want return. I don't know if that is possible or a good idea for the information you want to get out of the kernel, but it seems like a more natural interface, as it already has some of the same data (comm, gid, pid, ppid, ...). Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/