Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbbBRMFy (ORCPT ); Wed, 18 Feb 2015 07:05:54 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:43743 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbbBRMFw (ORCPT ); Wed, 18 Feb 2015 07:05:52 -0500 Message-ID: <54E4801C.9070801@cogentembedded.com> Date: Wed, 18 Feb 2015 15:05:48 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ruslan Bilovol , balbi@ti.com CC: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, k.opasiak@samsung.com, stern@rowland.harvard.edu, peter.chen@freescale.com, gregkh@linuxfoundation.org, andrzej.p@samsung.com Subject: Re: [PATCHv3 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure References: <1424207877-30915-1-git-send-email-ruslan.bilovol@gmail.com> <1424207877-30915-2-git-send-email-ruslan.bilovol@gmail.com> In-Reply-To: <1424207877-30915-2-git-send-email-ruslan.bilovol@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2124 Lines: 73 Hello. On 2/18/2015 12:17 AM, Ruslan Bilovol wrote: > Introduce new 'udc_name' member to usb_gadget_driver structure. > The 'udc_name' is a name of UDC that usb_gadget_driver should > be bound to. If udc_name is NULL, it will be bound to any > available UDC. > Signed-off-by: Ruslan Bilovol > --- > drivers/usb/gadget/udc/udc-core.c | 25 ++++++++++++++++++++----- > include/linux/usb/gadget.h | 4 ++++ > 2 files changed, 24 insertions(+), 5 deletions(-) > diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c > index 5a81cb0..e1079e08 100644 > --- a/drivers/usb/gadget/udc/udc-core.c > +++ b/drivers/usb/gadget/udc/udc-core.c > @@ -440,21 +440,36 @@ EXPORT_SYMBOL_GPL(usb_udc_attach_driver); > int usb_gadget_probe_driver(struct usb_gadget_driver *driver) > { > struct usb_udc *udc = NULL; > - int ret; > + int ret = -ENODEV; > > if (!driver || !driver->bind || !driver->setup) > return -EINVAL; > > mutex_lock(&udc_lock); > - list_for_each_entry(udc, &udc_list, list) { > - /* For now we take the first one */ > - if (!udc->driver) > + if (driver->udc_name) { > + list_for_each_entry(udc, &udc_list, list) { > + ret = strcmp(driver->udc_name, dev_name(&udc->dev)); > + if (!ret) > + break; > + } > + if (ret) > + ret = -ENODEV; > + else if (udc->driver) > + ret = -EBUSY; > + else > goto found; > + } else { > + list_for_each_entry(udc, &udc_list, list) { > + /* For now we take the first one */ > + if (!udc->driver) > + goto found; > + } > + ret = -ENODEV; Already assigned the same value by the initializer. > } > > pr_debug("couldn't find an available UDC\n"); > mutex_unlock(&udc_lock); > - return -ENODEV; > + return ret; > found: > ret = udc_bind_to_driver(udc, driver); > mutex_unlock(&udc_lock); [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/