From: Matt Fleming <matt@codeblueprint.co.uk>
Date: Wed, 18 Feb 2015 13:04:36 +0000
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc: linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org,
        leif.lindholm@linaro.org
Subject: Re: [Patch v2] firmware: dmi_scan: fix dmi scan to handle "End of
 Table" structure
Message-ID: <20150218130436.GB5648@codeblueprint.co.uk>
References: <1423059725-5448-1-git-send-email-ivan.khoronzhuk@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423059725-5448-1-git-send-email-ivan.khoronzhuk@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1211
Lines: 31

On Wed, 04 Feb, at 04:22:05PM, Ivan Khoronzhuk wrote:
> The dmi-sysfs should create "End of Table" entry, that is type 127.
> But after adding initial SMBIOS v3 support the 127-0 entry is not
> handled any more, as result it's not created in sysfs.
> This is important because the size of whole DMI table must correspond
> to sum of all DMI entry sizes.
> 
> So move "end-of-table" check after it's handled by decode.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> 
> v2..v1:
> 	Move end of table check after it's handled instead of removing
> 	Correct commit
> 
>  drivers/firmware/dmi_scan.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

The way that the commit log is written makes this sound like a
regression. If that's the case, then you need to list which commit
introduced the regression, because that will tell me whether it needs
tagging for stable.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/