Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbbBRNQe (ORCPT ); Wed, 18 Feb 2015 08:16:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34263 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbbBRNQc (ORCPT ); Wed, 18 Feb 2015 08:16:32 -0500 Message-ID: <54E490AA.3020301@suse.de> Date: Wed, 18 Feb 2015 14:16:26 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Lukasz Majewski CC: Eduardo Valentin , Kamil Debski , Jean Delvare , Guenter Roeck , Kukjin Kim , lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan Subject: Re: [PATCH v4 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-5-git-send-email-l.majewski@samsung.com> In-Reply-To: <1424254056-5904-5-git-send-email-l.majewski@samsung.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2420 Lines: 80 Am 18.02.2015 um 11:07 schrieb Lukasz Majewski: > From: Kamil Debski > > Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the > cooling fan. In addition, add the "pwm" label to the pwm@139D0000 node > in the exynos4412.dtsi. > > Signed-off-by: Kamil Debski > [Rebased on the newest mainline by l.majewski@samsung.com] You need to sign off patches you submit. > --- > Changes since v1: > - added pwm label to the pwm@139D0000 node in exynos4.dtsi > - use the pwm label in the exynos4412-odroidu3.dts > - change order or properties in the pwn-fan node, to be sorted > in alphabetical order > > --- > arch/arm/boot/dts/exynos4.dtsi | 2 +- > arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index f18d746..75266e3 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -582,7 +582,7 @@ > status = "disabled"; > }; > > - pwm@139D0000 { > + pwm: pwm@139D0000 { > compatible = "samsung,exynos4210-pwm"; > reg = <0x139D0000 0x1000>; > interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>; > diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts > index c8a64be..60bd1e4 100644 > --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts > +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts > @@ -31,6 +31,19 @@ > linux,default-trigger = "heartbeat"; > }; > }; > + > + pwm-fan { > + compatible = "pwm-fan"; > + pwms = <&pwm 0 10000 0>; > + status = "okay"; Status "okay" is only needed for pre-existing nodes that would have status "disabled" otherwise, such as below. Just drop it here. Regards, Andreas > + }; > +}; > + > +&pwm { > + pinctrl-0 = <&pwm0_out>; > + pinctrl-names = "default"; > + samsung,pwm-outputs = <0>; > + status = "okay"; > }; > > &usb3503 { > -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/