Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbbBRNUN (ORCPT ); Wed, 18 Feb 2015 08:20:13 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:43047 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbbBRNUL (ORCPT ); Wed, 18 Feb 2015 08:20:11 -0500 Message-ID: <54E49185.6080000@linaro.org> Date: Wed, 18 Feb 2015 15:20:05 +0200 From: Ivan Khoronzhuk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Matt Fleming CC: linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, leif.lindholm@linaro.org Subject: Re: [Patch v2] firmware: dmi_scan: fix dmi scan to handle "End of Table" structure References: <1423059725-5448-1-git-send-email-ivan.khoronzhuk@linaro.org> <20150218130436.GB5648@codeblueprint.co.uk> In-Reply-To: <20150218130436.GB5648@codeblueprint.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 36 Ok, I'll correct commit msg like: But after adding initial SMBIOS v3 support (fc43026278b23b3515cf8f909ec29df94b3ae1a2) the 127-0 entry is nothandled any more, as result it's not created in sysfs. On 02/18/2015 03:04 PM, Matt Fleming wrote: > On Wed, 04 Feb, at 04:22:05PM, Ivan Khoronzhuk wrote: >> The dmi-sysfs should create "End of Table" entry, that is type 127. >> But after adding initial SMBIOS v3 support the 127-0 entry is not >> handled any more, as result it's not created in sysfs. >> This is important because the size of whole DMI table must correspond >> to sum of all DMI entry sizes. >> >> So move "end-of-table" check after it's handled by decode. >> >> Signed-off-by: Ivan Khoronzhuk >> --- >> >> v2..v1: >> Move end of table check after it's handled instead of removing >> Correct commit >> >> drivers/firmware/dmi_scan.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) > The way that the commit log is written makes this sound like a > regression. If that's the case, then you need to list which commit > introduced the regression, because that will tell me whether it needs > tagging for stable. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/