Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbbBROw5 (ORCPT ); Wed, 18 Feb 2015 09:52:57 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:39293 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbbBROw4 (ORCPT ); Wed, 18 Feb 2015 09:52:56 -0500 From: Matt Fleming X-Google-Original-From: Matt Fleming Date: Wed, 18 Feb 2015 14:52:52 +0000 To: Ivan Khoronzhuk Cc: linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org, leif.lindholm@linaro.org Subject: Re: [Patch v3] firmware: dmi_scan: fix dmi scan to handle "End of Table" structure Message-ID: <20150218145252.GC5648@codeblueprint.co.uk> References: <1424267501-27172-1-git-send-email-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424267501-27172-1-git-send-email-ivan.khoronzhuk@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 22 On Wed, 18 Feb, at 03:51:41PM, Ivan Khoronzhuk wrote: > The dmi-sysfs should create "End of Table" entry, that is type 127. > But after adding initial SMBIOS v3 support > fc43026278b2 (dmi: add support for SMBIOS 3.0 64-bit entry point) > the 127-0 entry is not handled any more, as result it's not created > in dmi sysfs for instance. This is important because the size of > whole DMI table must correspond to sum of all DMI entry sizes. > > So move the end-of-table check after it's handled by dmi_table. > > Reviewed-by: Ard Biesheuvel > Signed-off-by: Ivan Khoronzhuk Applied and tagged for stable (v3.19+), thanks Ivan! -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/