Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbbBRPBv (ORCPT ); Wed, 18 Feb 2015 10:01:51 -0500 Received: from mail9.hitachi.co.jp ([133.145.228.44]:55479 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbbBRPBu (ORCPT ); Wed, 18 Feb 2015 10:01:50 -0500 Message-ID: <54E4A957.3050705@hitachi.com> Date: Thu, 19 Feb 2015 00:01:43 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Miroslav Benes Cc: jpoimboe@redhat.com, sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz, pmladek@suse.cz, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: remove extern specifier from header files References: <1424269267-1671-1-git-send-email-mbenes@suse.cz> In-Reply-To: <1424269267-1671-1-git-send-email-mbenes@suse.cz> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2266 Lines: 65 (2015/02/18 23:21), Miroslav Benes wrote: > Storage-class specifier 'extern' is redundant in front of the function > declaration. According to the C specification it has the same meaning as > if not present at all. So remove it. > > Signed-off-by: Miroslav Benes Looks good to me. Reviewed-by: Masami Hiramatsu > --- > arch/x86/include/asm/livepatch.h | 4 ++-- > include/linux/livepatch.h | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/include/asm/livepatch.h b/arch/x86/include/asm/livepatch.h > index a455a53..2d29197 100644 > --- a/arch/x86/include/asm/livepatch.h > +++ b/arch/x86/include/asm/livepatch.h > @@ -32,8 +32,8 @@ static inline int klp_check_compiler_support(void) > #endif > return 0; > } > -extern int klp_write_module_reloc(struct module *mod, unsigned long type, > - unsigned long loc, unsigned long value); > +int klp_write_module_reloc(struct module *mod, unsigned long type, > + unsigned long loc, unsigned long value); > > static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip) > { > diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h > index 95023fd..ee6dbb3 100644 > --- a/include/linux/livepatch.h > +++ b/include/linux/livepatch.h > @@ -123,10 +123,10 @@ struct klp_patch { > enum klp_state state; > }; > > -extern int klp_register_patch(struct klp_patch *); > -extern int klp_unregister_patch(struct klp_patch *); > -extern int klp_enable_patch(struct klp_patch *); > -extern int klp_disable_patch(struct klp_patch *); > +int klp_register_patch(struct klp_patch *); > +int klp_unregister_patch(struct klp_patch *); > +int klp_enable_patch(struct klp_patch *); > +int klp_disable_patch(struct klp_patch *); > > #endif /* CONFIG_LIVEPATCH */ > > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/