Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbbBRP2K (ORCPT ); Wed, 18 Feb 2015 10:28:10 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:45048 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbbBRP2I convert rfc822-to-8bit (ORCPT ); Wed, 18 Feb 2015 10:28:08 -0500 MIME-Version: 1.0 In-Reply-To: <1424255886-20330-1-git-send-email-geert@linux-m68k.org> References: <1424255886-20330-1-git-send-email-geert@linux-m68k.org> Date: Wed, 18 Feb 2015 07:28:07 -0800 Message-ID: Subject: Re: [PATCH] net: Initialize all members in skb_gro_remcsum_init() From: Tom Herbert To: Geert Uytterhoeven Cc: "David S. Miller" , Linux Netdev List , LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 45 On Wed, Feb 18, 2015 at 2:38 AM, Geert Uytterhoeven wrote: > skb_gro_remcsum_init() initializes the gro_remcsum.delta member only, > leading to compiler warnings about a possibly uninitialized > gro_remcsum.offset member: > > drivers/net/vxlan.c: In function ‘vxlan_gro_receive’: > drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this function > net/ipv4/fou.c: In function ‘gue_gro_receive’: > net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function > > While these are harmless for now: > - skb_gro_remcsum_process() sets offset before changing delta, > - skb_gro_remcsum_cleanup() checks if delta is non-zero before > accessing offset, > it's safer to let the initialization function initialize all members. > Acked-by: Tom Herbert > Signed-off-by: Geert Uytterhoeven > --- > include/linux/netdevice.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 5897b4ea5a3f9e0f..429d1790a27e85f3 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -2342,6 +2342,7 @@ struct gro_remcsum { > > static inline void skb_gro_remcsum_init(struct gro_remcsum *grc) > { > + grc->offset = 0; > grc->delta = 0; > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/