Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbbBRPpm (ORCPT ); Wed, 18 Feb 2015 10:45:42 -0500 Received: from eso.teric.us ([69.164.192.171]:45702 "EHLO eso.teric.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbBRPpk (ORCPT ); Wed, 18 Feb 2015 10:45:40 -0500 Date: Wed, 18 Feb 2015 09:39:18 -0600 From: Josh Cartwright To: Gilad Avidov Cc: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, iivanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH V3 1/2] spmi: remove wakeup command before slave probe Message-ID: <20150218153918.GB3485@kryptos> References: <1423522272-24472-1-git-send-email-gavidov@codeaurora.org> <1423522272-24472-2-git-send-email-gavidov@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423522272-24472-2-git-send-email-gavidov@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 28 On Mon, Feb 09, 2015 at 03:51:11PM -0700, Gilad Avidov wrote: > According to spmi spec a slave powers up into startup state and then > transitions into active state. Thus, the wakeup command is not required > before calling the slave's probe. The wakeup command is only needed for > slaves that are in sleep state after receiving the sleep command. > > This is a bug since spmi master controllers, such as spmi-pmic-arb, > which have no support for wakeup command return an error on that > command and thus fail before reaching a slave driver probe. If masters are required by the spec to support all commands as Stephen mentions, then I'd argue this is not a bug in the core code at all, but in the spmi-pmic-arb driver. But, unfortunately, having lost access to the spec, I'll defer. Regardless, I think this is useful as an optimization, just with dubious justification. Therefore, Acked-by: Josh Cartwright Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/