Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932157AbbBRTsn (ORCPT ); Wed, 18 Feb 2015 14:48:43 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:62602 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932070AbbBRTs3 (ORCPT ); Wed, 18 Feb 2015 14:48:29 -0500 From: Arnd Bergmann To: David Airlie Cc: dri-devel@lists.freedesktop.org, Vincent Palatin , Andrew Bresticker , Sean Paul , Rahul Sharma , Ajay Kumar , Javier Martinez Canillas , Thierry Reding , Inki Dae , Sjoerd Simons , Gustavo Padovan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: drm: bridge: ps8622 and ptn3460 depend on gpiolib Date: Wed, 18 Feb 2015 17:09:25 +0100 Message-ID: <19803561.otRxsE7o5u@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:4dwT5LatA/PE83RukRDoujxTMlLmgL4Y6o61IP0pWerrOTNTyww k9zDsQFgNT77r+evrFdg2UdRdZRBcHlMA2IpEOX/9jV1hMeRdLnqMnkX+FOcrx2m3IKUpH5 l8r28BBAPxhd/3NCHGb3FWAd72Wf8YLyFTAmto6v2MOOaIih2/qRZt17QDKA3uEFPfofAQz YnLsrUL3gtqSNLU+KSpLg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 48 The ptn3460 driver recently started usign the gpiod interface which is only available on platforms that come with GPIOLIB support, resulting in a compile-time error: drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable': drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] gpiod_set_value(ps8622->gpio_rst, 0); ^ drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe': drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration] ps8622->gpio_slp = devm_gpiod_get(dev, "sleep"); ^ Similarly, the newly added ps8622 driver started out with the same problem. This patch adds explicit Kconfig dependencies to avoid trying to build invalid configurations. Signed-off-by: Arnd Bergmann Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge") Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface") diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index acef3223772c..8f068a0e86a5 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -7,6 +7,7 @@ config DRM_PTN3460 tristate "PTN3460 DP/LVDS bridge" depends on DRM depends on OF + depends on GPIOLIB select DRM_KMS_HELPER select DRM_PANEL ---help--- @@ -16,6 +17,7 @@ config DRM_PS8622 tristate "Parade eDP/LVDS bridge" depends on DRM depends on OF + depends on GPIOLIB select DRM_PANEL select DRM_KMS_HELPER select BACKLIGHT_LCD_SUPPORT -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/