Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbbBRQJ7 (ORCPT ); Wed, 18 Feb 2015 11:09:59 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:50367 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbbBRQJ6 (ORCPT ); Wed, 18 Feb 2015 11:09:58 -0500 X-ME-Helo: beldin X-ME-Date: Wed, 18 Feb 2015 17:09:57 +0100 X-ME-IP: 90.16.210.142 From: Robert Jarzmik To: Ezequiel Garcia Cc: David Woodhouse , Brian Norris , Maxime Ripard , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt References: <1424203617-29431-1-git-send-email-robert.jarzmik@free.fr> <54E47ABF.8070306@free-electrons.com> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 18 Feb 2015 17:09:52 +0100 In-Reply-To: <54E47ABF.8070306@free-electrons.com> (Ezequiel Garcia's message of "Wed, 18 Feb 2015 08:42:55 -0300") Message-ID: <8738639p67.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 23 Ezequiel Garcia writes: >> +static irqreturn_t pxa3xx_nand_irq_thread(int irq, void *data) >> +{ >> + struct pxa3xx_nand_info *info = data; >> + >> + handle_data_pio(info); >> + >> + info->state = STATE_CMD_DONE; > > Are you sure you need to set the state here? Euh no, I'm not. I made it to be symmetric with dma_complete_func(). If it's not needed, why is it needed in dma_complete_func() ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/