Message-ID: <54E4E567.2060403@suse.de>
Date: Wed, 18 Feb 2015 20:17:59 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Organization: SUSE Linux GmbH
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
CC: Sangbeom Kim <sbkim73@samsung.com>, alsa-devel@alsa-project.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        Doug Anderson <dianders@chromium.org>,
        Vincent Palatin <vpalatin@chromium.org>,
        Lars-Peter Clausen <lars@metafoo.de>, Takashi Iwai <tiwai@suse.de>,
        Xiubo Li <Li.Xiubo@freescale.com>, Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Tomasz Figa <tomasz.figa@gmail.com>,
        Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] ASoC: max98088: Add DT bindings
References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-3-git-send-email-afaerber@suse.de> <54E4E33C.9040301@cogentembedded.com>
In-Reply-To: <54E4E33C.9040301@cogentembedded.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1917
Lines: 59

Hi,

Am 18.02.2015 um 20:08 schrieb Sergei Shtylyov:
> On 02/18/2015 09:25 PM, Andreas Färber wrote:
> 
>> "maxim,max98089" will be used for the Spring Chromebook.
> 
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>   sound/soc/codecs/max98088.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
> 
>> diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
>> index 805b3f8cd39d..69a21d1946e3 100644
>> --- a/sound/soc/codecs/max98088.c
>> +++ b/sound/soc/codecs/max98088.c
>> @@ -2009,10 +2009,18 @@ static const struct i2c_device_id
>> max98088_i2c_id[] = {
>>   };
>>   MODULE_DEVICE_TABLE(i2c, max98088_i2c_id);
>>
>> +static const struct of_device_id max98088_of_match[] = {
> 
>    If I don't mistake, gcc will complain about this variable being
> unused if CONFIG_OF=n.

I assume there will be no warning because of the "const".
For just "static" you would be right.

>> +    { .compatible = "maxim,max98088" },
>> +    { .compatible = "maxim,max98089" },
>> +    { }
>> +};
>> +MODULE_DEVICE_TABLE(of, max98088_of_match);
>> +
>>   static struct i2c_driver max98088_i2c_driver = {
>>       .driver = {
>>           .name = "max98088",
>>           .owner = THIS_MODULE,
>> +        .of_match_table = of_match_ptr(max98088_of_match),
> 
>    You probably don;t need of_match_ptr(). Either that or do something
> with the match table, like enclosing into #ifdef or annotating with
> '__maybe_unused'.

This was copied from max98090 and max98095.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/