Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbbBRTXG (ORCPT ); Wed, 18 Feb 2015 14:23:06 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:41279 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753252AbbBRTXF (ORCPT ); Wed, 18 Feb 2015 14:23:05 -0500 From: OGAWA Hirofumi To: Alexander Kuleshov Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/fat: remove fat12_ent_blocknr and use fat_ent_blocknr instead References: <1424286782-1726-1-git-send-email-kuleshovmail@gmail.com> Date: Thu, 19 Feb 2015 04:23:01 +0900 In-Reply-To: <1424286782-1726-1-git-send-email-kuleshovmail@gmail.com> (Alexander Kuleshov's message of "Thu, 19 Feb 2015 01:13:02 +0600") Message-ID: <87d257owh6.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 18 Alexander Kuleshov writes: > There is only one difference between fat12_ent_blocknr and fat_ent_blocknr > functions in bytes calculation. Let's add bits checking to fat_ent_blocknr > instead code duplication. I guess, fat12 (very small volume size) is uncommon to be used now, and there is no way to switch fat12 <= fat16/fat32 at runtime. It is why has special handler, i.e. avoid overhead to fat16/fat32 by fat12 code. Thanks. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/