Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbbBRUZl (ORCPT ); Wed, 18 Feb 2015 15:25:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53227 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbbBRUZk (ORCPT ); Wed, 18 Feb 2015 15:25:40 -0500 Date: Wed, 18 Feb 2015 15:25:23 -0500 From: Benjamin Tissoires To: Nikolai Kondrashov Cc: Jiri Kosina , Peter Hutterer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, DIGImend-devel Subject: Re: [PATCH 1/2] HID: huion: enable button mode reporting Message-ID: <20150218202523.GE5928@mail.corp.redhat.com> References: <1424213653-5970-1-git-send-email-benjamin.tissoires@redhat.com> <1424213653-5970-2-git-send-email-benjamin.tissoires@redhat.com> <54E482EA.7070507@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54E482EA.7070507@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2819 Lines: 50 On Feb 18 2015 or thereabouts, Nikolai Kondrashov wrote: > On 02/18/2015 12:54 AM, Benjamin Tissoires wrote: > >@@ -81,6 +84,31 @@ static const __u8 huion_tablet_rdesc_template[] = { > > HUION_PH(PRESSURE_LM), /* Logical Maximum (PLACEHOLDER), */ > > 0x81, 0x02, /* Input (Variable), */ > > 0xC0, /* End Collection, */ > >+ 0x05, 0x01, /* Usage Page (Desktop) */ > >+ 0x09, 0x07, /* Usage (Keypad) */ > >+ 0xa1, 0x01, /* Collection (Application) */ > >+ 0x85, 0x08, /* Report ID (8) */ > > Oh, and it's probably safer to have a higher-number report ID in case some > tablets use it for something else. > makes sense. Will amend. Cheers, Benjamin > >+ 0x05, 0x0d, /* Usage Page (Digitizers) */ > >+ 0x09, 0x22, /* Usage (Finger) */ > >+ 0xa0, /* Collection (Physical) */ > >+ 0x14, /* Logical Minimum (0) */ > >+ 0x25, 0x01, /* Logical Maximum (1) */ > >+ 0x75, 0x08, /* Report Size (8) */ > >+ 0x95, 0x03, /* Report Count (3) */ > >+ 0x81, 0x03, /* Input (Cnst,Var,Abs) */ > >+ 0x05, 0x09, /* Usage Page (Button) */ > >+ 0x19, 0x01, /* Usage Minimum (1) */ > >+ 0x29, 0x08, /* Usage Maximum (8) */ > >+ 0x14, /* Logical Minimum (0) */ > >+ 0x25, 0x01, /* Logical Maximum (1) */ > >+ 0x75, 0x01, /* Report Size (1) */ > >+ 0x95, 0x08, /* Report Count (8) */ > >+ 0x81, 0x02, /* Input (Data,Var,Abs) */ > >+ 0x75, 0x08, /* Report Size (8) */ > >+ 0x95, 0x03, /* Report Count (3) */ > >+ 0x81, 0x03, /* Input (Cnst,Var,Abs) */ > >+ 0xc0, /* End Collection */ > >+ 0xc0, /* End Collection */ > > 0xC0 /* End Collection */ > > }; > > Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/