Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753091AbbBRWn4 (ORCPT ); Wed, 18 Feb 2015 17:43:56 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43800 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946AbbBRWnz (ORCPT ); Wed, 18 Feb 2015 17:43:55 -0500 Date: Wed, 18 Feb 2015 23:43:52 +0100 (CET) From: Jiri Kosina To: Benjamin Tissoires cc: Ping Cheng , Benjamin Tissoires , Jason Gerecke , linux-input , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation In-Reply-To: Message-ID: References: <1424200786-4009-1-git-send-email-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 33 On Tue, 17 Feb 2015, Benjamin Tissoires wrote: > On Tue, Feb 17, 2015 at 5:36 PM, Ping Cheng wrote: > > On Tue, Feb 17, 2015 at 11:19 AM, Benjamin Tissoires > > wrote: > >> input_mt_sync_frame() calls input_mt_report_pointer_emulation() and do > >> some internal steps required to keep in sync the state of the touch within > >> the various reports. > >> > >> Given that we use input_mt_assign_slot() in this driver, it is better to > >> use input_mt_sync_frame(). > > > > It is sensible to me, except I think you meant input_mt_slot() instead > > of input_mt_assign_slot(). > > Hehe, I should have actually checked the call. I meant > input_mt_get_slot_by_key(). > > > > >> Signed-off-by: Benjamin Tissoires > > > > Reviewed-by: Ping Cheng Applied (with adjusted changelog). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/