Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbbBRWw7 (ORCPT ); Wed, 18 Feb 2015 17:52:59 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44311 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbbBRWw6 (ORCPT ); Wed, 18 Feb 2015 17:52:58 -0500 Date: Wed, 18 Feb 2015 23:52:56 +0100 (CET) From: Jiri Kosina To: simon@mungewell.org cc: =?ISO-8859-1?Q?=22Michal_Mal=C3=BD=22?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: hid-lg4ff: Fix "undefined reference" build issue with CONFIG_USB disabled. In-Reply-To: Message-ID: References: <1424296173-22718-1-git-send-email-madcatxster@devoid-pointer.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 22 On Wed, 18 Feb 2015, simon@mungewell.org wrote: > > Fix "undefined reference" build issue with CONFIG_USB disabled. > > Just a newbie question... for a family of devices (the wheels) which can > only be attached via USB, wouldn't the better approach be to fix the > dependancy? > > Are there any other devices provided for by 'hid-logitech' which use any > other transport (HID over Bluetooth or the like)? Using only HID API (and let it call to the transport driver) is much cleaner way and helps a lot with avoiding code duplication, etc. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/