Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384AbbBSDXr (ORCPT ); Wed, 18 Feb 2015 22:23:47 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:51157 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbbBSDXq (ORCPT ); Wed, 18 Feb 2015 22:23:46 -0500 MIME-Version: 1.0 X-Originating-IP: [76.119.162.148] In-Reply-To: <1424304641-28965-2-git-send-email-dbueso@suse.de> References: <1424304641-28965-1-git-send-email-dbueso@suse.de> <1424304641-28965-2-git-send-email-dbueso@suse.de> Date: Wed, 18 Feb 2015 22:23:45 -0500 Message-ID: Subject: Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file From: Paul Moore To: Davidlohr Bueso Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, Eric Paris , linux-audit@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 54 On Wed, Feb 18, 2015 at 7:10 PM, Davidlohr Bueso wrote: > From: Davidlohr Bueso > > This patch adds a audit_log_d_path_exe() helper function > to share how we handle auditing of the exe_file's path. > Used by both audit and auditsc. No functionality is changed. > > Cc: Paul Moore > Cc: Eric Paris > Cc: linux-audit@redhat.com > Signed-off-by: Davidlohr Bueso > --- > > Compile tested only. > > kernel/audit.c | 9 +-------- > kernel/audit.h | 14 ++++++++++++++ > kernel/auditsc.c | 9 +-------- > 3 files changed, 16 insertions(+), 16 deletions(-) I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline. > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -257,6 +257,20 @@ extern struct list_head audit_filter_list[]; > > extern struct audit_entry *audit_dupe_rule(struct audit_krule *old); > > +static inline void audit_log_d_path_exe(struct audit_buffer *ab, > + struct mm_struct *mm) > +{ > + if (!mm) { > + audit_log_format(ab, " exe=(null)"); > + return; > + } > + > + down_read(&mm->mmap_sem); > + if (mm->exe_file) > + audit_log_d_path(ab, " exe=", &mm->exe_file->f_path); > + up_read(&mm->mmap_sem); > +} > + > /* audit watch functions */ > #ifdef CONFIG_AUDIT_WATCH > extern void audit_put_watch(struct audit_watch *watch); -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/