Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbbBSFii (ORCPT ); Thu, 19 Feb 2015 00:38:38 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:42795 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbbBSFig (ORCPT ); Thu, 19 Feb 2015 00:38:36 -0500 Message-ID: <1424324307.18191.5.camel@stgolabs.net> Subject: Re: [PATCH 3/3] tomoyo: robustify handling of mm->exe_file From: Davidlohr Bueso To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, takedakn@nttdata.co.jp, penguin-kernel@I-love.SAKURA.ne.jp, linux-security-module@vger.kernel.org Date: Wed, 18 Feb 2015 21:38:27 -0800 In-Reply-To: <1424304641-28965-4-git-send-email-dbueso@suse.de> References: <1424304641-28965-1-git-send-email-dbueso@suse.de> <1424304641-28965-4-git-send-email-dbueso@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 31 On Wed, 2015-02-18 at 16:10 -0800, Davidlohr Bueso wrote: > +static const char *tomoyo_get_exe(struct mm_struct *mm) > +{ > + struct file *exe_file; > + const char *cp = NULL; > + > + if (!mm) > + return NULL; > + exe_file = get_mm_exe_file(mm); > + if (!exe_file) > + return NULL; > + > + cp = tomoyo_realpath_from_path(&exe_file->f_path); tomoyo_realpath_from_path can return NULL here, thus we'd leak the f_path in the caller... I guess this should be: > + path_get(&exe_file->f_path); if (cp) path_get(&exe_file->f_path); > + fput(exe_file); > + return cp; > +} -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/