Message-ID: <54E58A61.60200@linux.vnet.ibm.com>
Date: Thu, 19 Feb 2015 12:31:53 +0530
From: Preeti U Murthy <preeti@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>
CC: linux-kernel@vger.kernel.org, mingo@kernel.org, rjw@rjwysocki.net,
        tglx@linutronix.de
Subject: Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based
 broadcasting
References: <20150216121435.203983131@infradead.org> <20150216122413.880378334@infradead.org> <54E2BDA1.3040003@linux.vnet.ibm.com> <20150217103946.GD21418@twins.programming.kicks-ass.net> <54E402BC.2010709@linux.vnet.ibm.com> <20150218130614.GT5029@twins.programming.kicks-ass.net>
In-Reply-To: <20150218130614.GT5029@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1161
Lines: 32

On 02/18/2015 06:36 PM, Peter Zijlstra wrote:
> On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote:
>>
>> Look at the changelog, 
> 
> Heh, yah, clearly I tl;dr'd that. Indeed.
> 
>> it explains why tick_takeover must be called
>> *before* __cpu_die(). 
> 
> Since you reported this, can you test if things work if you move that
> function call to before __cpu_die() ?

Yes it does. I had tested and posted out a patch to fix the issue
here:https://lkml.org/lkml/2015/1/30/821. I see now that tglx proposes
to get rid of "taking over" tick duties going forward, rather "handing
over" tick duties would be better. So the patch in the above link would
not be acceptable. But minus the taking over of the do_timer, the cpu
doing the hotplug takes over broadcast duty before __cpu_die() in this
patch. This design works.

Regards
Preeti U Murthy
> 
> I _think_ it should be fine, but what do I know ;-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/