Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbbBSIOj (ORCPT ); Thu, 19 Feb 2015 03:14:39 -0500 Received: from mga02.intel.com ([134.134.136.20]:32042 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbbBSIOh (ORCPT ); Thu, 19 Feb 2015 03:14:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,607,1418112000"; d="scan'208";a="680224990" Date: Thu, 19 Feb 2015 16:14:32 +0800 From: kbuild test robot To: "Bryan O'Donoghue" Cc: kbuild-all@01.org, Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, Andy Shevchenko , "Ong, Boon Leong" , Darren Hart , linux-kernel@vger.kernel.org Subject: [PATCH] x86/intel/quark: fix simple_return.cocci warnings Message-ID: <20150219081432.GA21996@waimea> References: <201502191606.pTcFEBOs%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201502191606.pTcFEBOs%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 34 arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Bryan O'Donoghue Signed-off-by: Fengguang Wu --- imr.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/arch/x86/platform/intel-quark/imr.c +++ b/arch/x86/platform/intel-quark/imr.c @@ -126,12 +126,8 @@ static int imr_read(struct imr_device *i if (ret) return ret; - ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ, + return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ, reg++, &imr->wmask); - if (ret) - return ret; - - return 0; } /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/