Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbbBSIOi (ORCPT ); Thu, 19 Feb 2015 03:14:38 -0500 Received: from mga14.intel.com ([192.55.52.115]:56474 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbbBSIOh (ORCPT ); Thu, 19 Feb 2015 03:14:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,607,1418112000"; d="scan'208";a="654233691" Date: Thu, 19 Feb 2015 16:14:32 +0800 From: kbuild test robot To: "Bryan O'Donoghue" Cc: kbuild-all@01.org, Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, Andy Shevchenko , "Ong, Boon Leong" , Darren Hart , linux-kernel@vger.kernel.org Subject: [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings Message-ID: <20150219081432.GA21983@waimea> References: <201502191606.pTcFEBOs%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201502191606.pTcFEBOs%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 33 arch/x86/platform/intel-quark/imr.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Bryan O'Donoghue Signed-off-by: Fengguang Wu --- imr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/arch/x86/platform/intel-quark/imr.c +++ b/arch/x86/platform/intel-quark/imr.c @@ -277,10 +277,7 @@ static int imr_debugfs_register(struct i { idev->file = debugfs_create_file("imr_state", S_IFREG | S_IRUGO, NULL, idev, &imr_state_ops); - if (IS_ERR(idev->file)) - return PTR_ERR(idev->file); - - return 0; + return PTR_ERR_OR_ZERO(idev->file); } /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/